From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9FF121FF187 for ; Fri, 19 Dec 2025 14:52:15 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2EFF0CF43; Fri, 19 Dec 2025 14:53:05 +0100 (CET) Mime-Version: 1.0 Date: Fri, 19 Dec 2025 14:53:01 +0100 Message-Id: To: "Lukas Wagner" X-Mailer: aerc 0.20.0 References: <20251218142007.279631-1-l.wagner@proxmox.com> In-Reply-To: <20251218142007.279631-1-l.wagner@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1766152368688 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager/proxmox-yew-comp v2 0/6] manual refresh button for remote task cache X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Thu Dec 18, 2025 at 3:20 PM CET, Lukas Wagner wrote: > This adds the > POST /remotes/tasks/refresh[?remote=...] > > endpoint for manually triggering task collection from a single or all remotes. > > The task viewer component is changed so that the refresh button can be wired > up to trigger this new endpoint. > > Changes since v1: > - Drop the patch which adds the task descriptions of the new > refresh-task - this one is now included in another patch series > - Fix a bug where the view would not automatically display new tasks > after the refresh task finished > > > proxmox-yew-comp: > > Lukas Wagner (2): > task list: add support for starting refresh tasks > loadable component: don't trigger reload when starting a task > > src/loadable_component.rs | 1 - > src/tasks.rs | 21 ++++++++++++++++++++- > 2 files changed, 20 insertions(+), 2 deletions(-) > > > proxmox-datacenter-manager: > > Lukas Wagner (4): > remote tasks: move implementation to server crate > remote tasks: implement `refresh_task_cache` for manual task fetching > api: add /remotes/tasks/refresh > ui: remote task view: set refresh_task_url property for task viewer > > server/src/api/remote_tasks.rs | 90 ++- > .../tasks/remote_tasks.rs | 535 +---------------- > server/src/remote_tasks/mod.rs | 1 + > server/src/remote_tasks/refresh_task.rs | 544 ++++++++++++++++++ > ui/src/remotes/tasks.rs | 14 +- > 5 files changed, 650 insertions(+), 534 deletions(-) > create mode 100644 server/src/remote_tasks/refresh_task.rs > > > Summary over all repositories: > 7 files changed, 670 insertions(+), 536 deletions(-) took a look at this series, generally the changes look good to me, just had two smaller notes that i left on the respective patches. so consider this: Reviewed-by: Shannon Sterz _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel