From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0D14B1FF17A for ; Tue, 9 Dec 2025 15:51:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2BA694F51; Tue, 9 Dec 2025 15:52:32 +0100 (CET) Mime-Version: 1.0 Date: Tue, 09 Dec 2025 15:52:29 +0100 Message-Id: From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Proxmox Datacenter Manager development discussion" Cc: "pdm-devel" X-Mailer: aerc 0.21.0 References: <20251205180447.441371-1-s.shaji@proxmox.com> <20251205180447.441371-5-s.shaji@proxmox.com> In-Reply-To: <20251205180447.441371-5-s.shaji@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765291943234 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [remotes.rs] Subject: Re: [pdm-devel] [PATCH datacenter-manager 4/5] cli: client: add `delete-token` option to delete token from remote X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" shouldn't this also be implemented for the admin CLI? On Fri Dec 5, 2025 at 7:04 PM CET, Shan Shaji wrote: > Signed-off-by: Shan Shaji > --- > cli/client/src/remotes.rs | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/cli/client/src/remotes.rs b/cli/client/src/remotes.rs > index 4145dac..0b4df3c 100644 > --- a/cli/client/src/remotes.rs > +++ b/cli/client/src/remotes.rs > @@ -116,12 +116,17 @@ async fn update_remote(id: String, updater: RemoteUpdater) -> Result<(), Error> > input: { > properties: { > id: { schema: REMOTE_ID_SCHEMA }, > + "delete-token": { > + type: bool, > + optional: true, > + description: "Remove the API-Token from remote." > + } > } > } > )] > -/// Add a new remote. > -async fn delete_remote(id: String) -> Result<(), Error> { > - client()?.delete_remote(&id).await?; > +/// Delete a remote. > +async fn delete_remote(id: String, delete_token: Option) -> Result<(), Error> { > + client()?.delete_remote(&id, &delete_token).await?; > Ok(()) > } > _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel