From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BBC781FF17A for ; Tue, 9 Dec 2025 14:38:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5CEFD214C; Tue, 9 Dec 2025 14:38:52 +0100 (CET) Mime-Version: 1.0 Date: Tue, 09 Dec 2025 14:38:48 +0100 Message-Id: From: "Lukas Wagner" To: "Proxmox Datacenter Manager development discussion" , "Christoph Heiss" X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20251205112528.373387-1-c.heiss@proxmox.com> In-Reply-To: <20251205112528.373387-1-c.heiss@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765287522428 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.117 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH proxmox/datacenter-manager v2 00/14] initial auto-installer integration X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Great work in general! Tried this out on the latest master, seems to work as advertised. Tested-by: Lukas Wagner I found one small issue while testing, it seems like when you have a 'default' prepared answer which you then edit (keeping 'default' checked), then one gets the follwowing error: 'configuration 'test' is already the default answer' On Fri Dec 5, 2025 at 12:25 PM CET, Christoph Heiss wrote: > This series adds integration with our automated installer [0] for all our > products. With this, Proxmox Datacenter Manager can be used for serving > answer files via HTTP(S) in an automated fashion. > > It provides two new panels: > > - Automated Installations: List all past and currently ongoing > installations. > - Prepared Answers: Enables users to do the whole CRUD cycle for > prepared answers, i.e. create new answers (from scratch or based on > existing ones), edit and delete. > > Permission-wise, everything is currently scoped on > /system/auto-installation. > > UI > == > > Happy about feedback regarding the UI, especially the editing dialog! By > the nature of it, the auto-installer has a lot more options than the > standard GUI/TUI installer, and it's kind of hard to not fully cramp up > the UI while still providing all options. > > The viewing of the system information and post-installation hook > notification data is a bit bare-bones. For the first one, maybe > displaying it as a tree (see also future work) could be a possibility, > if we don't want to simply display raw JSON documents to the user. > > TOML API > ======== > > The auto-installer (currently) only supports TOML as input format for > the answer, so we need to hack around a bit to serve TOML in the API. > This is done in patch #12, by implementing the api method > directly. > > Serving TOML from an endpoint under /api2/json/ obviously is rather > wrong, so I'm definitely open for suggestions. > We probably also don't want to implement `/api2/toml/` if I'd have to > guess (or would that be possible selectively, i.e. just for this one > endpoint?). > > Adding JSON support to proxmox-fetch-answer is on my list, but this > would still be needed if we want to keep compatibility with older ISOs. > > Other future work > ================= > > - Switch the installer to use the `proxmox-installer-types` crate too > Left this out for now (though I have a mostly-done branch locally > already), to ease review. > > - Target filter selection by dropdown/tree > Based on the system information schema, a list of all possible > JSON pointers, or even a tree, could be generated and displayed to the > user, in a form consisting of the key, a text input for the value/glob > to match and a set of add/remove buttons for each filter. > > - Display/saving the installation progress/log. The progress log > generated by the auto-installer can be sent to PDM, showing it there > similar to tasks. > Requires changes to the auto-installer, so this would not be > backwards-compatible with older ISOs. Not sure if worth the effort, but it could also be cool to 'stream' the logs to PDM, so that one can get a.) a progress bar of the installation status, and b.) the live output from the installation > > - Implement a "wait for answer"-ish system. Core idea here is that the > installer waits for PDM to provide in answer by implemented e.g. an > retry system. The use case is for to be able to effectively install > systems on demand, without the need for preparations. > Again requires changes to the auto-installer and wouldn't be > backwards-compatible. > Some different things that came to mind that could be cool: - Have some (basic) integration for the prepare-iso tool, where one could automatically download and generate an ISO that is configured with the correct URL/fingerprint and also the shared secret that I mentioned in one of the patches - Ability to add the new node as a remote, either automatically after it has been installed or on button-press from the 'Installations' screen (automatic could be tricky, since the root password of the node is never stored; manual could simply spawn the 'Add Remote' dialog prefilled with the values we already know) - Add a quick link in the 'Installations' page to open the web interface of the installed node. _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel