From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 1569F1FF17A
	for <inbox@lore.proxmox.com>; Tue,  9 Dec 2025 10:35:30 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 7CD1D20CA2;
	Tue,  9 Dec 2025 10:36:09 +0100 (CET)
Mime-Version: 1.0
Date: Tue, 09 Dec 2025 10:36:07 +0100
Message-Id: <DETL1HUMXFOW.FYLJYVXQ4INO@proxmox.com>
To: "Shan Shaji" <s.shaji@proxmox.com>
X-Mailer: aerc 0.20.0
References: <20251205180447.441371-1-s.shaji@proxmox.com>
 <20251205180447.441371-4-s.shaji@proxmox.com>
In-Reply-To: <20251205180447.441371-4-s.shaji@proxmox.com>
From: "Shannon Sterz" <s.sterz@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1765272961782
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.091 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pdm-devel] [PATCH datacenter-manager 3/5] pdm-client: accept
 `delete-token` argument for deleting api token
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
 <pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>, 
 <mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>, 
 <mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
 <pdm-devel@lists.proxmox.com>
Cc: Proxmox Datacenter Manager development discussion
 <pdm-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>

On Fri Dec 5, 2025 at 7:04 PM CET, Shan Shaji wrote:
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>  lib/pdm-client/src/lib.rs | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/pdm-client/src/lib.rs b/lib/pdm-client/src/lib.rs
> index 01ee6f7..872d78d 100644
> --- a/lib/pdm-client/src/lib.rs
> +++ b/lib/pdm-client/src/lib.rs
> @@ -136,8 +136,10 @@ impl<T: HttpApiClient> PdmClient<T> {
>          Ok(())
>      }
>
> -    pub async fn delete_remote(&self, remote: &str) -> Result<(), Error> {
> -        let path = format!("/api2/extjs/remotes/remote/{remote}");
> +    pub async fn delete_remote(&self, remote: &str, delete_token: &Option<bool>) -> Result<(), Error> {

nit: add a doc comment to this public function since you are touching it
already.

> +        let path = ApiPathBuilder::new(format!("/api2/extjs/remotes/remote/{remote}"))
> +            .maybe_arg("delete-token", delete_token)
> +            .build();
>          self.0.delete(&path).await?.nodata()?;
>          Ok(())
>      }



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel