From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E662C1FF17A for ; Tue, 9 Dec 2025 10:35:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5570D20C12; Tue, 9 Dec 2025 10:36:03 +0100 (CET) Mime-Version: 1.0 Date: Tue, 09 Dec 2025 10:36:01 +0100 Message-Id: To: "Shan Shaji" X-Mailer: aerc 0.20.0 References: <20251205180447.441371-1-s.shaji@proxmox.com> <20251205180447.441371-2-s.shaji@proxmox.com> In-Reply-To: <20251205180447.441371-2-s.shaji@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765272955504 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.091 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager 1/5] server: pbs-client: add delete admin token method X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Fri Dec 5, 2025 at 7:04 PM CET, Shan Shaji wrote: > Inorder to allow deleting the generated token of PBS from PDM, add > method inside the PbsClient to delete the admin token. > > Signed-off-by: Shan Shaji > --- > server/src/pbs_client.rs | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/server/src/pbs_client.rs b/server/src/pbs_client.rs > index f4f1f82..b1e01e1 100644 > --- a/server/src/pbs_client.rs > +++ b/server/src/pbs_client.rs > @@ -260,7 +260,14 @@ impl PbsClient { > Ok(token) > } > > - /// Return the status the Proxmox Backup Server instance > + // Delete API-Token from the PBS remote. nit: dropping a '/' here turns this from a doc comment to a regular comment. since this is a public function, please specify this as a doc comment. > + pub async fn delete_admin_token(&self, userid: &Userid, tokenid: &str) -> Result<(), Error> { > + let path = format!("/api2/extjs/access/users/{userid}/token/{tokenid}"); > + self.0.delete(&path).await?.nodata()?; > + Ok(()) > + } > + > + /// Return the status the Proxmox Backup Server instance: nit: any reason to add a colon here? > pub async fn node_status(&self) -> Result { > let path = "/api2/extjs/nodes/localhost/status"; > Ok(self.0.get(path).await?.expect_json()?.data) _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel