From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 90B331FF17A
	for <inbox@lore.proxmox.com>; Tue,  9 Dec 2025 10:13:10 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 15D82200F1;
	Tue,  9 Dec 2025 10:13:49 +0100 (CET)
Mime-Version: 1.0
Date: Tue, 09 Dec 2025 10:13:41 +0100
Message-Id: <DETKKBQXLX6T.29SWLRBK3YXZD@proxmox.com>
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Datacenter Manager development discussion"
 <pdm-devel@lists.proxmox.com>, "Christoph Heiss" <c.heiss@proxmox.com>
X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty
References: <20251205112528.373387-1-c.heiss@proxmox.com>
 <20251205112528.373387-4-c.heiss@proxmox.com>
In-Reply-To: <20251205112528.373387-4-c.heiss@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1765271616301
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.022 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 T_SPF_HELO_TEMPERROR     0.01 SPF: test of HELO record failed (temperror)
 T_SPF_TEMPERROR          0.01 SPF: test of record failed (temperror)
Subject: Re: [pdm-devel] [PATCH proxmox v2 03/14] network-types: implement
 api type for Fqdn
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
 <pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>, 
 <mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>, 
 <mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
 <pdm-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>

On Fri Dec 5, 2025 at 12:25 PM CET, Christoph Heiss wrote:
> Pretty straight-forward, as we already got a fitting regex defined for a
> FQDN.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> Changes v1 -> v2:
>   * no changes
>
>  proxmox-network-types/src/fqdn.rs | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/proxmox-network-types/src/fqdn.rs b/proxmox-network-types/src/fqdn.rs
> index 9582639d..3c1bd475 100644
> --- a/proxmox-network-types/src/fqdn.rs
> +++ b/proxmox-network-types/src/fqdn.rs
> @@ -2,6 +2,9 @@
>  
>  use std::{fmt, str::FromStr};
>  
> +#[cfg(feature = "api-types")]
> +use proxmox_schema::UpdaterType;
> +
>  use serde::Deserialize;
>  
>  /// Possible errors that might occur when parsing FQDNs.
> @@ -55,6 +58,7 @@ impl fmt::Display for FqdnParseError {
>  /// [RFC4343]: <https://www.ietf.org/rfc/rfc4343.txt>
>  /// [hostname(7)]: <https://manpages.debian.org/stable/manpages/hostname.7.en.html>
>  #[derive(Clone, Debug, Eq)]
> +#[cfg_attr(feature = "api-types", derive(UpdaterType))]
>  pub struct Fqdn {
>      parts: Vec<String>,
>  }
> @@ -132,6 +136,16 @@ impl Fqdn {
>      }
>  }
>  
> +#[cfg(feature = "api-types")]
> +impl proxmox_schema::ApiType for Fqdn {
> +    const API_SCHEMA: proxmox_schema::Schema =
> +        proxmox_schema::StringSchema::new("Fully-qualified domain name")
> +            .format(&proxmox_schema::ApiStringFormat::Pattern(
> +                &proxmox_schema::api_types::DNS_NAME_REGEX,
> +            ))
> +            .schema();
> +}
> +
>  impl FromStr for Fqdn {
>      type Err = FqdnParseError;
>  



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel