From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3076D1FF178 for ; Mon, 1 Dec 2025 09:54:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EE4D115D04; Mon, 1 Dec 2025 09:55:19 +0100 (CET) Mime-Version: 1.0 Date: Mon, 01 Dec 2025 09:55:15 +0100 Message-Id: From: "Lukas Wagner" To: "Proxmox Datacenter Manager development discussion" , "Thomas Lamprecht" X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20251128130124.2738745-1-d.csapak@proxmox.com> In-Reply-To: <20251128130124.2738745-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764579273275 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [RFC PATCH proxmox] pve api types: percent encode string params in url X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Fri Nov 28, 2025 at 1:59 PM CET, Dominik Csapak wrote: > when we generate an url for the pve api from something like > > "/some/{foo}/thing/{bar}" > > then the url we generate will be wrapped in a `format!` and the > variables `foo` and `bar` will be inserted into the url. > > Sometimes, these parameters can contain invalid characters for a url and > we have to percent encode them. > > To do that, we convert the url to one with unnamed parameters and add > them with percent encoding. > > The order of the url_params is the same as in the url, so we don't > have to to a lookup or similar, simply iterating over that is enough. > > This fixes an issue with UPIDs that contain the character '>'. > (e.g. move disk from one vm to another). > > Signed-off-by: Dominik Csapak > --- > sending as RFC, because there is a (not so generic) alternative: > we could simply percent encode the upid ourselves in pdm, whenever > we call the pve api. I think handling encoding at this level as implemented in this patch is exactly right. > > but since this wasn't too hard to do and everything seems to work > in my (albeit short) tests, I wanted to send it and gather feedback. > > pve-api-types/generator-lib/Schema2Rust.pm | 29 +++++++++++++++++++++- > pve-api-types/src/client/code.rs | 2 ++ > 2 files changed, 30 insertions(+), 1 deletion(-) > Couldn't find anything that looked off. Everything seems to work fine after applying this patch, refreshing the bindings and building PDM with them. Verified in the browser console that non-alphanumeric characters are indeed percent-encoded. Also spot-checked the diff of the generated code, everything that I saw looked reasonable. Reviewed-by: Lukas Wagner Tested-by: Lukas Wagner _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel