From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7CB231FF165 for ; Thu, 6 Nov 2025 12:21:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 43C7014443; Thu, 6 Nov 2025 12:22:04 +0100 (CET) Mime-Version: 1.0 Date: Thu, 06 Nov 2025 12:21:30 +0100 Message-Id: To: "Dominik Csapak" X-Mailer: aerc 0.20.0 References: <20251028164435.576642-1-s.sterz@proxmox.com> <09ee9512-de05-4a49-8b36-7fd5eef2dd72@proxmox.com> In-Reply-To: <09ee9512-de05-4a49-8b36-7fd5eef2dd72@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762428071578 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs, lib.rs, main.rs, api.rs, proxmox.com, status.rs, acl.rs, types.rs] Subject: Re: [pdm-devel] [PATCH datacenter-manager/proxmox/yew-comp 0/6] add node status panel to proxmox datacenter manager X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Mon Nov 3, 2025 at 2:15 PM CET, Dominik Csapak wrote: > One high level comment: > > Since it is a panel with tools, etc. it looks a bit weird > in the tab panel due to it being just one element > > It'll look better when we add the RRD graphs of the node > (when we have that), since then it looks more like the other > places where we have panels. yes which is why i send that commit as an rfc. imo, it would make sense to turn this into a widget one can use for a view once that feature is applied. should be fairly straight forward, what do you think? > Other than that and the few nits and one issue i commented, > consider this series: adapted the nits, since none of them changed anything substantial, i'll keep your trailers for a v2, hope that alright. > Reviewed-by: Dominik Csapak > Tested-by: Dominik Csapak > > On 10/28/25 5:45 PM, Shannon Sterz wrote: >> this series adds a node status panel to the administration menu of >> proxmox datacenter manager. it allows for getting a rough overview of >> system load as well as accessing the node's fingerprint and rebooting >> and powering off the node. >> >> the fist patch moves the api endpoints from proxmox-backup server to >> their own proxmox-rs crate. the next two commits extend yew-comp to >> allow implementing a node status panel of the newly extracted api >> endpoints return types. >> >> the next three commits first add the new api endpoints to proxmox >> datacenter manager, add the ui panel to the Administration menu and >> remove a suproflous macro. >> >> the last two commits are sent as RFC, as i am not sure whether we want >> to have the panel in that menu or should maybe treat it as a widget for >> the new view feature. while the last commit is just a clean up >> suggestion i came accross while implementing this. >> >> proxmox: >> >> Shannon Sterz (1): >> node-status: add node status crate >> >> Cargo.toml | 1 + >> proxmox-node-status/Cargo.toml | 37 +++++ >> proxmox-node-status/debian/changelog | 5 + >> proxmox-node-status/debian/control | 65 ++++++++ >> proxmox-node-status/debian/copyright | 18 +++ >> proxmox-node-status/debian/debcargo.toml | 7 + >> proxmox-node-status/src/api.rs | 184 +++++++++++++++++++++++ >> proxmox-node-status/src/lib.rs | 11 ++ >> proxmox-node-status/src/types.rs | 184 +++++++++++++++++++++++ >> 9 files changed, 512 insertions(+) >> create mode 100644 proxmox-node-status/Cargo.toml >> create mode 100644 proxmox-node-status/debian/changelog >> create mode 100644 proxmox-node-status/debian/control >> create mode 100644 proxmox-node-status/debian/copyright >> create mode 100644 proxmox-node-status/debian/debcargo.toml >> create mode 100644 proxmox-node-status/src/api.rs >> create mode 100644 proxmox-node-status/src/lib.rs >> create mode 100644 proxmox-node-status/src/types.rs >> >> >> proxmox-yew-comp: >> >> Shannon Sterz (2): >> node info: extend NodeStatus enum to include NodeStatus from >> proxmox-rs >> node status panel: add a panel that show the current status of a node >> >> Cargo.toml | 1 + >> src/lib.rs | 3 + >> src/node_info.rs | 38 ++++++ >> src/node_status_panel.rs | 244 +++++++++++++++++++++++++++++++++++++++ >> 4 files changed, 286 insertions(+) >> create mode 100644 src/node_status_panel.rs >> >> >> proxmox-datacenter-manager: >> >> Shannon Sterz (3): >> api-types/api: add endpoints for querying the node's status >> ui: add NodeStatusPanel to the administration menu >> nodes: remove unnecessary rustfmt::skip macro >> >> Cargo.toml | 2 ++ >> lib/pdm-api-types/src/acl.rs | 2 ++ >> server/Cargo.toml | 1 + >> server/src/api/nodes/mod.rs | 3 ++- >> server/src/api/nodes/status.rs | 18 ++++++++++++++++++ >> server/src/bin/proxmox-datacenter-api/main.rs | 2 ++ >> ui/src/administration/mod.rs | 15 ++++++++++++++- >> 7 files changed, 41 insertions(+), 2 deletions(-) >> create mode 100644 server/src/api/nodes/status.rs >> >> >> Summary over all repositories: >> 20 files changed, 839 insertions(+), 2 deletions(-) >> >> -- >> Generated by git-murpp 0.8.1 >> >> >> _______________________________________________ >> pdm-devel mailing list >> pdm-devel@lists.proxmox.com >> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel >> >> _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel