From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4A7861FF15C for ; Fri, 17 Oct 2025 11:36:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C7342249B1; Fri, 17 Oct 2025 11:36:21 +0200 (CEST) Date: Fri, 17 Oct 2025 11:36:17 +0200 Message-Id: Cc: "pdm-devel" From: "Lukas Wagner" To: "Proxmox Datacenter Manager development discussion" Mime-Version: 1.0 X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20251014143709.413690-1-s.sterz@proxmox.com> <20251014143709.413690-4-s.sterz@proxmox.com> In-Reply-To: <20251014143709.413690-4-s.sterz@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1760693774377 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs] Subject: Re: [pdm-devel] [PATCH datacenter-manager v2 1/3] ui: add a token panel and a token acl edit menu in the permissions panel X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Looks good to me: Tested-by: Lukas Wagner Reviewed-by: Lukas Wagner On Tue Oct 14, 2025 at 4:37 PM CEST, Shannon Sterz wrote: > this allows users to create and manage api tokens. > > Signed-off-by: Shannon Sterz > --- > ui/src/configuration/mod.rs | 33 +++++++++++++++++++++++++++------ > 1 file changed, 27 insertions(+), 6 deletions(-) > > diff --git a/ui/src/configuration/mod.rs b/ui/src/configuration/mod.rs > index 0a92796..4110f39 100644 > --- a/ui/src/configuration/mod.rs > +++ b/ui/src/configuration/mod.rs > @@ -7,7 +7,7 @@ use pwt::widget::{Container, MiniScrollMode, Panel, TabBarItem, TabPanel}; > use proxmox_yew_comp::configuration::TimePanel; > use proxmox_yew_comp::configuration::{DnsPanel, NetworkView}; > use proxmox_yew_comp::tfa::TfaView; > -use proxmox_yew_comp::{AclEdit, AclView, AuthView, UserPanel}; > +use proxmox_yew_comp::{AclEdit, AclView, AuthView, TokenPanel, UserPanel}; > > mod permission_path_selector; > mod webauthn; > @@ -73,6 +73,19 @@ pub fn access_control() -> Html { > .into() > }, > ) > + .with_item_builder( > + TabBarItem::new() > + .key("api-tokens") > + .icon_class("fa fa-user-o") > + .label(tr!("API Token")), > + |_| { > + Container::new() > + .class("pwt-content-spacer") > + .class(pwt::css::FlexFit) > + .with_child(TokenPanel::new()) > + .into() > + }, > + ) > .with_item_builder( > TabBarItem::new() > .key("two-factor") > @@ -95,11 +108,19 @@ pub fn access_control() -> Html { > Container::new() > .class("pwt-content-spacer") > .class(pwt::css::FlexFit) > - .with_child(AclView::new().with_acl_edit_menu_entry( > - tr!("User Permission"), > - "fa fa-fw fa-user", > - acl_edit.clone().use_tokens(false), > - )) > + .with_child( > + AclView::new() > + .with_acl_edit_menu_entry( > + tr!("User Permission"), > + "fa fa-fw fa-user", > + acl_edit.clone().use_tokens(false), > + ) > + .with_acl_edit_menu_entry( > + tr!("Token Permission"), > + "fa fa-fw fa-user-o", > + acl_edit.clone().use_tokens(true), > + ), > + ) > .into() > }, > ) _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel