From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9CB831FF187 for ; Mon, 22 Sep 2025 14:49:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 178791B511; Mon, 22 Sep 2025 14:50:14 +0200 (CEST) Mime-Version: 1.0 Date: Mon, 22 Sep 2025 14:50:11 +0200 Message-Id: From: "Lukas Wagner" To: "Proxmox Datacenter Manager development discussion" , "Christian Ebner" X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250922110958.369653-1-c.ebner@proxmox.com> In-Reply-To: <20250922110958.369653-1-c.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758545399788 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager 0/6] ui/api: implement and expose adding PBS remotes via the ui wizard X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Mon Sep 22, 2025 at 1:09 PM CEST, Christian Ebner wrote: > While it is already possible to add PBS remote via the cli, the UI currently > does not expose this functionality. Most of the required pieces are however > already there, so implement the missing api endpoints to check the TLS > connection and scan the remote for the PDM api and add the required methods to > the PDM client. > > Finally, make sure the correct PDM implementation for PBS is used based on the > remote type as stored in the remote add wizard state and expose the button > to add the PBS instance. > > datacenter-manager: > > Christian Ebner (6): > server: api: add TLS probe endpoint for PBS > pdm-client: add method to probe TLS connection for PBS remotes > server: api: implement endpoint to scan remote PBS instances > pdm client: add method to scan remote PBS instances > ui: remote: check connection for PBS remotes in remote add wizard > ui: reorganize remote add button as dropdown menu to allow adding PBS > > lib/pdm-client/src/lib.rs | 90 +++++++++++++++------- > server/src/api/pbs/mod.rs | 107 ++++++++++++++++++++++++-- > ui/src/remotes/add_wizard.rs | 2 +- > ui/src/remotes/config.rs | 42 +++++----- > ui/src/remotes/wizard_page_connect.rs | 16 ++-- > ui/src/remotes/wizard_page_info.rs | 25 ++++-- > 6 files changed, 211 insertions(+), 71 deletions(-) > > > Summary over all repositories: > 6 files changed, 211 insertions(+), 71 deletions(-) Looks good to me. I applied this on the latest master and give it a spin. Reviewed-by: Lukas Wagner Tested-by: Lukas Wagner The only thing that I noticed is that when creating a new API token via the wizard, further API calls to actually give this new token adequate permissions are needed, since PBS enforces privilege-separation for API tokens. For PVE this is not a problem, since there we just don't use privilege-separation, so the token has the same privs as the user. _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel