From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2C83A1FF185 for ; Mon, 18 Aug 2025 14:40:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A139237C0D; Mon, 18 Aug 2025 14:41:56 +0200 (CEST) Mime-Version: 1.0 Date: Mon, 18 Aug 2025 14:41:53 +0200 Message-Id: From: "Lukas Wagner" To: "Proxmox Datacenter Manager development discussion" , "Dominik Csapak" X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250516133611.3499075-1-d.csapak@proxmox.com> In-Reply-To: <20250516133611.3499075-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755520874088 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager 00/21] improve remote wizard X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Fri May 16, 2025 at 3:35 PM CEST, Dominik Csapak wrote: > # Summary > > This series improves the remote wizard in various points: > * improved wording and texts > * moved seperate buttons on pages into the next button > * probing of entered nodes > * confirmation dialog for missing fingerprints > * better realm selector > > # Notes > > I'm not super sure about the API call structure. I think two seperate > API calls (one for tls probing, one for scanning) might make more sense. > If that's wanted, I'll do so in a v2 of the series. > > ## Probing on the server side > > I tried to determine if we need a fingerprint for nodes inside the > API call, by probing each node. Since we currently only get the > nodenames and not FQDNs in the nodelist, this will currently not > result in a valid connection in most cases and return the fingerprint. > > My plan would be to include FQDNs of the nodes on the PVE side API call, > so we can return here a list of nodename, ip and FQDNs, which the user > then can select from. (which of those I'd probe on first check is yet > to be determined) > > ## Fingerprint confirmation dialogs > > Not sure if we want to be able to let the user confirm the fingerprint > so easily. On one hand it's very convenient, but maybe leads to users > simply clicking yes without understanding what's happening. > > If it's deemed too dangerous, I'd rework the series without this. > > # Future work > > The next step for the wizard is to have some kind of quick copy&paste > info. After discussing off-list with Fabian a bit, I think it would be > best for this to contain the hostname (FQDN?) + fingerprint (if just a > self-signed certificate) + a list of nodes with their respective > nodename + FQDNs (maybe requires api change on PVE side to generate > this). The user would then still have to do most of the steps currently > necessary in the wizard, except the manual copy & pasting of > fingerprints and maybe entering of FQDNs. > > Seems like these do not apply cleanly any more, could you rebase and send a v2? Thanks! _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel