From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pdm-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 710311FF16F for <inbox@lore.proxmox.com>; Thu, 30 Jan 2025 09:02:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 673A59E80; Thu, 30 Jan 2025 09:02:02 +0100 (CET) Message-ID: <9817b471-10b5-44a4-9468-23cdb35226ef@proxmox.com> Date: Thu, 30 Jan 2025 09:01:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht <t.lamprecht@proxmox.com>, Proxmox Datacenter Manager development discussion <pdm-devel@lists.proxmox.com> References: <20250128122520.167796-1-l.wagner@proxmox.com> <20250128122520.167796-5-l.wagner@proxmox.com> <76713e70-f964-4e4c-85a4-b39c916ff7e5@proxmox.com> Content-Language: de-AT, en-US From: Lukas Wagner <l.wagner@proxmox.com> In-Reply-To: <76713e70-f964-4e4c-85a4-b39c916ff7e5@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH proxmox-datacenter-manager 04/15] task cache: remove max-age machanism X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion <pdm-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>, <mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/> List-Post: <mailto:pdm-devel@lists.proxmox.com> List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>, <mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Datacenter Manager development discussion <pdm-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com> On 2025-01-29 19:27, Thomas Lamprecht wrote: > Am 28.01.25 um 13:25 schrieb Lukas Wagner: >> This commit removes the time-based caching policy for remote tasks. It >> will be replaced by another cache replacement policy based on total >> number of tasks in an upcoming commit. > > high-level: Such commits really should state a rationale with some > background over why this approach has to be replaced. Noting that in > the cover letter too would also be appreciated, such things help to > "sell" series/PRs and having the underlying goal and/or pain points > spelled out, even if quite obvious, ensures everyone is on the same > page. > > Similar comment for the next patch adding the FIFO replacement policy, > I won't write a separate mail for that. > Ah yeah sure, sorry about that. Dominik (and Dietmar briefly as well) suggested this approach to me and after some thoughts I agreed this was better. Since this came from 'higher up', the 'why' was somewhat settled, at least in my head, and I guess that's why I kinda forgot to explain it in the commit message. Of course you are a 100% correct, the rationale should be included in the commit log for future reference. I'll wait for further reviews and then try to expand the commit messages for a v2, if that's alright with you. Thanks! -- - Lukas _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel