Re: [pdm-devel] [PATCH proxmox-datacenter-manager 04/15] task cache: remove max-age machanism

[Lukas Wagner <l.wagner@proxmox.com>]

On  2025-01-29 19:27, Thomas Lamprecht wrote:
> Am 28.01.25 um 13:25 schrieb Lukas Wagner:
>> This commit removes the time-based caching policy for remote tasks. It
>> will be replaced by another cache replacement policy based on total
>> number of tasks in an upcoming commit.
> 
> high-level: Such commits really should state a rationale with some
> background over why this approach has to be replaced. Noting that in
> the cover letter too would also be appreciated, such things help to
> "sell" series/PRs and having the underlying goal and/or pain points
> spelled out, even if quite obvious, ensures everyone is on the same
> page.
> 
> Similar comment for the next patch adding the FIFO replacement policy,
> I won't write a separate mail for that.
> 

Ah yeah sure, sorry about that.

Dominik (and Dietmar briefly as well) suggested this approach to me and after some thoughts
I agreed this was better. Since this came from 'higher up', the 'why' was somewhat settled,
at least in my head, and I guess that's why I kinda forgot to explain it in the commit message.
Of course you are a 100% correct, the rationale should be included in the commit log for future reference.
I'll wait for further reviews and then try to expand the commit messages for a v2, if that's alright with you.

Thanks!

-- 
- Lukas



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel