From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 70EEB1FF16F for ; Tue, 19 Aug 2025 10:08:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E0946F3C1; Tue, 19 Aug 2025 10:10:43 +0200 (CEST) Message-ID: <9341dc82-4654-4ba8-933c-84ed27d0b88e@proxmox.com> Date: Tue, 19 Aug 2025 10:10:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Lukas Wagner , Proxmox Datacenter Manager development discussion References: <20250606121028.2595348-1-d.csapak@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755590998234 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [node.rs, qemu.rs, proxmox.com, lxc.rs] Subject: Re: [pdm-devel] [PATCH datacenter-manager 0/3] add rrd time frame selector for pve panels X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On 8/18/25 14:30, Lukas Wagner wrote: > On Fri Jun 6, 2025 at 2:10 PM CEST, Dominik Csapak wrote: >> this series adds an rrd time frame selector to qemu/lxc/node panels for >> pve. >> >> note that my recent series[0] for improving the rrd graphs should be >> applied first, otherwise there are some situations where the yew >> application can easily panic. >> >> 0: https://lore.proxmox.com/yew-devel/20250530122202.2779300-1-d.csapak@proxmox.com/T/#t >> >> Dominik Csapak (3): >> ui: pve: qemu: add rrd time frame selector >> ui: pve: lxc: add rrd time frame selector >> ui: pve: nodes: add rrd time frame selector >> >> ui/src/pve/lxc.rs | 26 ++++++++++++++++++-------- >> ui/src/pve/node.rs | 33 ++++++++++++++++++++++----------- >> ui/src/pve/qemu.rs | 26 ++++++++++++++++++-------- >> 3 files changed, 58 insertions(+), 27 deletions(-) > > Looks good to me. > > Reviewed-by: Lukas Wagner > Tested-by: Lukas Wagner > > (I can apply these if you want, but I didn't so far since I'm not > familiar at all with the UI code yet) > imo you can apply it, but we must bump the yew-comp dependency to 0.5.6 (which is just being uploaded), otherwise we can easily generate panics when switching between the ranges _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel