From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0E7891FF141 for ; Tue, 05 May 2026 10:47:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DDAAF1F224; Tue, 5 May 2026 10:47:15 +0200 (CEST) Message-ID: <9130c192-b6fd-4557-8d99-63c9fb847415@proxmox.com> Date: Tue, 5 May 2026 10:46:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH datacenter-manager v2 1/4] lib/api/ui: add location property to remote config To: Thomas Lamprecht , pdm-devel@lists.proxmox.com References: <20260505073203.398548-1-d.csapak@proxmox.com> <20260505073203.398548-6-d.csapak@proxmox.com> <246ec646-b7cf-4570-88a7-089e066dc129@proxmox.com> <544eb1b9-eb2f-4094-8b96-57f5f7492058@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <544eb1b9-eb2f-4094-8b96-57f5f7492058@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777970694434 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TGZNC7OC45BF5PPS44C4HJK3POXNIXOF X-Message-ID-Hash: TGZNC7OC45BF5PPS44C4HJK3POXNIXOF X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/5/26 10:42 AM, Thomas Lamprecht wrote: > Am 05.05.26 um 10:35 schrieb Dominik Csapak: >> >> >> On 5/5/26 10:24 AM, Thomas Lamprecht wrote: >>> Am 05.05.26 um 09:31 schrieb Dominik Csapak: >>>> this will be used to show the remote on a map in a custom view. >>>> Let's the user simply enter the longitude and latitude in the remote >>>> edit window. >>> >>> Would be nicer and more fitting to have this on the remote side, i.e. the >>> node configs as metadata or similar format-string field. >>> >>> And one location per remote won't cut it for PVE. We know of clusters that >>> are distributed over different location with a few km distance in between >>> and a dark fiber channel for near LAN latency to upheld cluster communication >>> requirements. >> >> do you mean that the user configures that on the pve and pbs side per node? > > exactly what I meant. >> if yes, sure that is doable. I didn't go this way to not exclude >> users with older clusters (e.g. 8.4) to use that feature. >> also it's metadata that the pve nodes themselves won't really use > > If you really want to provide those old releases this features we can port > it back, that said, EOL is nearing for those (bit over ~3 months left), and > especially for this non-essential feature I'd just not bother with that. understood > > And why should we not show this on the PVE nodes themselves? And independent > of that it's in anyway a property of a PVE/ node and tied to that physical > location, not a property of a PDM remote config entry, which should IMO not > care about these things, at least not as primary source of such information > (overrides can be OK, but IMO not really justified here). yeah, you're right, i'll make it part of the node config for pve/pbs in a v3, thanks for the feedback!