public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pdm-devel] [PATCH datacenter-manager] ui: pve storage selector: fix the displayed values
@ 2025-01-07 13:23 Dominik Csapak
  2025-01-08 12:09 ` [pdm-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2025-01-07 13:23 UTC (permalink / raw)
  To: pdm-devel

we want to show 'available' and 'capacity' (indicated by the column
headers), but showed 'used' and 'available' respectively.

Fix this by using the correct values from the struct.

While at it, rename the intermediated variables to match what they are.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 ui/src/widget/pve_storage_selector.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/ui/src/widget/pve_storage_selector.rs b/ui/src/widget/pve_storage_selector.rs
index 188acc6..488175a 100644
--- a/ui/src/widget/pve_storage_selector.rs
+++ b/ui/src/widget/pve_storage_selector.rs
@@ -209,15 +209,15 @@ fn columns() -> Rc<Vec<DataTableHeader<StorageInfo>>> {
             .into(),
         DataTableColumn::new(tr!("Avail"))
             .get_property_owned(|entry: &StorageInfo| entry.used.unwrap_or_default())
-            .render(|entry: &StorageInfo| match entry.used {
-                Some(used) => html! {format!("{:.2}", HumanByte::new_decimal(used as f64))},
+            .render(|entry: &StorageInfo| match entry.avail {
+                Some(avail) => html! {format!("{:.2}", HumanByte::new_decimal(avail as f64))},
                 None => html! {"-"},
             })
             .into(),
         DataTableColumn::new(tr!("Capacity"))
             .get_property_owned(|entry: &StorageInfo| entry.avail.unwrap_or_default())
-            .render(|entry: &StorageInfo| match entry.avail {
-                Some(used) => html! { format!("{:.2}", HumanByte::new_decimal(used as f64))},
+            .render(|entry: &StorageInfo| match entry.total {
+                Some(total) => html! { format!("{:.2}", HumanByte::new_decimal(total as f64))},
                 None => html! {"-"},
             })
             .into(),
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pdm-devel] applied: [PATCH datacenter-manager] ui: pve storage selector: fix the displayed values
  2025-01-07 13:23 [pdm-devel] [PATCH datacenter-manager] ui: pve storage selector: fix the displayed values Dominik Csapak
@ 2025-01-08 12:09 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-01-08 12:09 UTC (permalink / raw)
  To: Proxmox Datacenter Manager development discussion, Dominik Csapak

On 07/01/2025 14:23, Dominik Csapak wrote:
> we want to show 'available' and 'capacity' (indicated by the column
> headers), but showed 'used' and 'available' respectively.
> 
> Fix this by using the correct values from the struct.
> 
> While at it, rename the intermediated variables to match what they are.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  ui/src/widget/pve_storage_selector.rs | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-01-08 12:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-07 13:23 [pdm-devel] [PATCH datacenter-manager] ui: pve storage selector: fix the displayed values Dominik Csapak
2025-01-08 12:09 ` [pdm-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal