From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A82821FF16F for ; Tue, 15 Apr 2025 13:52:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 92FE16E3D; Tue, 15 Apr 2025 13:52:55 +0200 (CEST) Message-ID: <704368b2-74a7-4c87-8e0c-c4b6d81284b3@proxmox.com> Date: Tue, 15 Apr 2025 13:52:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Wolfgang Bumiller References: <20250411140520.1475644-1-d.csapak@proxmox.com> <20250411140520.1475644-2-d.csapak@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH yew-comp 1/1] status: implement PartialEq and Clone for Status X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: pdm-devel@lists.proxmox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On 4/14/25 16:50, Wolfgang Bumiller wrote: > On Fri, Apr 11, 2025 at 04:05:17PM +0200, Dominik Csapak wrote: >> this is sensible to have, e.g. when we want to have the status structs >> as parto of a type for a store > > I'd argue these should all be: > > #[derive(Clone, Copy, Debug, Eq, PartialEq, Hash)] > sure, makes sense. is a follow up enough or should I resend the patch ( or whole series?) >> >> Signed-off-by: Dominik Csapak >> --- >> src/status.rs | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/src/status.rs b/src/status.rs >> index 9d951c5..ab77a15 100644 >> --- a/src/status.rs >> +++ b/src/status.rs >> @@ -7,6 +7,7 @@ use pwt::{ >> >> /// Used to represent a Status of some resource or component, e.g. >> /// if a PVE node is online or not. >> +#[derive(PartialEq, Clone)] >> pub enum Status { >> Success, >> Warning, >> @@ -27,6 +28,7 @@ impl Status { >> } >> >> /// Used to represent the state of a Node, being PVE or PBS >> +#[derive(PartialEq, Clone)] >> pub enum NodeState { >> Online, >> Offline, >> @@ -45,6 +47,7 @@ impl NodeState { >> } >> >> /// Used to represent the state of a PVE guest, such as a VM >> +#[derive(PartialEq, Clone)] >> pub enum GuestState { >> Running, >> Paused, >> @@ -67,6 +70,7 @@ impl GuestState { >> } >> >> /// Used to represent the state of a Storage or Datastore >> +#[derive(PartialEq, Clone)] >> pub enum StorageState { >> Available, >> Unavailable, >> -- >> 2.39.5 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel