From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pdm-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 728D11FF15E for <inbox@lore.proxmox.com>; Tue, 11 Feb 2025 15:50:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 242822F96F; Tue, 11 Feb 2025 15:50:15 +0100 (CET) Message-ID: <66752912-2026-4c4c-b1c1-2377e6cbe481@proxmox.com> Date: Tue, 11 Feb 2025 15:50:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Datacenter Manager development discussion <pdm-devel@lists.proxmox.com>, Wolfgang Bumiller <w.bumiller@proxmox.com> References: <20250204095554.39501-1-w.bumiller@proxmox.com> Content-Language: de-AT, en-US From: Lukas Wagner <l.wagner@proxmox.com> In-Reply-To: <20250204095554.39501-1-w.bumiller@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.010 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH pdm 0/7] multi-remote client and node reachability cache X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion <pdm-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>, <mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/> List-Post: <mailto:pdm-devel@lists.proxmox.com> List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>, <mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Datacenter Manager development discussion <pdm-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com> On 2025-02-04 10:55, Wolfgang Bumiller wrote: > This consists of two parts (and a question (at the end)): > > 1) Patches 1 through 3: > The `MultiClient` which implements cycling through multiple remotes > when requests fail due to network issues. > > 2) Patches 4 through 6: > A task caching the remote reachability state as well as mapping > hostnames to the pve-side node-names. Currently this simply runs every > 60 seconds and goes through the current remotes+nodes and checks for > reachability. > If at that time the remote.cfg changed and the polling > task is still ongoing it will be aborted and started over with the new > config. > Finally, the reachability information will be used and updated by the > `MultiClient` implementation. > > 3) Patch 7 is mainly for debugging. I'm not sure whether we want to include > tracing instrumentation in general, or via a `#[cfg_attr]` or only for > debug builds... I quite like the approach you took in patch 7 and used the same in my metric collection improvement patch series, so that's a +1 from me. Not a super deep review, but looked through the code tried to understand it and checked if anything looked off. Looks good to me. Reviewed-by: Lukas Wagner <l.wagner@proxmox.com> -- - Lukas _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel