Re: [pdm-devel] [PATCH pdm 0/7] multi-remote client and node reachability cache

[Lukas Wagner <l.wagner@proxmox.com>]

On  2025-02-04 10:55, Wolfgang Bumiller wrote:
> This consists of two parts (and a question (at the end)):
> 
> 1) Patches 1 through 3:
> The `MultiClient` which implements cycling through multiple remotes
> when requests fail due to network issues.
> 
> 2) Patches 4 through 6:
> A task caching the remote reachability state as well as mapping
> hostnames to the pve-side node-names. Currently this simply runs every
> 60 seconds and goes through the current remotes+nodes and checks for
> reachability.
> If at that time the remote.cfg changed and the polling
> task is still ongoing it will be aborted and started over with the new
> config.
> Finally, the reachability information will be used and updated by the
> `MultiClient` implementation.
> 
> 3) Patch 7 is mainly for debugging. I'm not sure whether we want to include
> tracing instrumentation in general, or via a `#[cfg_attr]` or only for
> debug builds...

I quite like the approach you took in patch 7 and used the same in my metric collection improvement
patch series, so that's a +1 from me.

Not a super deep review, but looked through the code tried to understand it and checked if anything
looked off. Looks good to me.

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>

-- 
- Lukas



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel