From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A52FC1FF13C for ; Thu, 02 Apr 2026 13:08:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E5B3C139F1; Thu, 2 Apr 2026 13:09:04 +0200 (CEST) Message-ID: <60f1a75d-7e19-4aa6-9940-16c7729f1efd@proxmox.com> Date: Thu, 2 Apr 2026 13:09:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH datacenter-manager] ui: pbs: add tasks to node tab panel To: Lukas Wagner , pdm-devel@lists.proxmox.com References: <20260309143827.3017628-1-d.csapak@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775128083817 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LQOUSULL7R5GE3UZ4GCOEY656K7QBQS5 X-Message-ID-Hash: LQOUSULL7R5GE3UZ4GCOEY656K7QBQS5 X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/2/26 12:54 PM, Lukas Wagner wrote: > On Mon Mar 9, 2026 at 3:37 PM CET, Dominik Csapak wrote: >> Similar to PVE, but since we don't have a 'Datacenter' tab panel, simply >> use the 'node' one, since there can only be one for PBS anyway. >> >> Signed-off-by: Dominik Csapak >> --- >> ui/src/pbs/node/mod.rs | 12 +++++++++++- >> 1 file changed, 11 insertions(+), 1 deletion(-) >> >> diff --git a/ui/src/pbs/node/mod.rs b/ui/src/pbs/node/mod.rs >> index abb1f6a6..6d2f46b8 100644 >> --- a/ui/src/pbs/node/mod.rs >> +++ b/ui/src/pbs/node/mod.rs >> @@ -17,7 +17,7 @@ pub(crate) mod overview; >> >> use overview::PbsNodeOverviewPanel; >> >> -use crate::get_deep_url_low_level; >> +use crate::{get_deep_url_low_level, remotes::RemoteTaskList}; >> >> #[derive(Clone, Debug, Eq, PartialEq, Properties)] >> pub struct PbsNodePanel { >> @@ -78,6 +78,16 @@ impl yew::Component for PbsNodePanelComp { >> move |_| PbsNodeOverviewPanel::new(remote.clone()).into() >> }, >> ) >> + .with_item_builder( >> + TabBarItem::new() >> + .key("tasks_view") >> + .label(tr!("Tasks")) >> + .icon_class("fa fa-list"), >> + { >> + let remote = props.remote.clone(); >> + move |_| RemoteTaskList::new().remote(remote.clone()).into() >> + }, >> + ) >> .with_item_builder( >> TabBarItem::new() >> .key("update_view") > > I wonder, should we also add a 'per-node' Tasks tab for PVE remotes? > What do you think? > mhmm can make sense, but maybe a better option would be to add a node selector to the tasks on datacenter level? (maybe both?) I just fear that we might overload the interface with too many options if we do this for everything (but that fear might be unfounded :P )