From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C11CF1FF16F for ; Tue, 30 Sep 2025 13:49:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1065B5C6B; Tue, 30 Sep 2025 13:49:25 +0200 (CEST) Date: Tue, 30 Sep 2025 13:49:21 +0200 From: Wolfgang Bumiller To: Christian Ebner Message-ID: <5jmcsjt7cdnnxghl3hxxfdph2m5euzydxrnpltt2vorp6o7b6s@6fu6j2jlsrqz> References: <20250930080207.111162-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250930080207.111162-1-c.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759232940683 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager/proxmox v2 0/6] pbs client: fix PBS version 3 login ticket parsing compatibility X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: pdm-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Tue, Sep 30, 2025 at 10:02:01AM +0200, Christian Ebner wrote: > This patches fix the ticket parsing when login to instances of PBS version 3 > or lower. For this, the current pve_compat flags for `Login` and `Client` > are refactored to be an extendable enum variant instead, adding the ticket > parsing backwards compatibility. In that compatibility mode, response parsing > of the ticket does not interpret the presence of the `ticket-info` field as the > ticket being a `http-only` ticket and fallsback to the PBS version 3 and 4 > compatible parsing, as the client never used `http-only` tickets. I thought this field was introduced only with http-only tickets, so why is it not a reliable indicator and shouldn't *that* be fixed instead? > > Since this fixes token generation and ACLs setting via the remote add wizard, > revert the now outdated warning of PBS v4 minimum requirement. > > Changes since version 1: > - Fix check for CompatMode::Pbs3Ticket in response ticket parsing, must skip the > http-only path. > - Set the compatibility mode on the client, not the login. The client propagates > the compat mode to the login on login() calls. Since that incorrectly set the > state, the PBS logic worked nevertheless during testing, but also affected the > PVE state, which was not intended. > > proxmox: > > Christian Ebner (3): > proxmox-login: refactor PVE TFA compat mode > proxmox-client: adapt to new compat mode introduced for proxmox-login > proxmox-login: add compat mode to fallback to PBS3 ticket parsing > > proxmox-client/src/client.rs | 12 ++++---- > proxmox-client/src/lib.rs | 2 +- > proxmox-login/src/lib.rs | 55 +++++++++++++++++++++++++----------- > 3 files changed, 45 insertions(+), 24 deletions(-) > > > datacenter-manager: > > Christian Ebner (3): > server: adapt to proxmox-client compat mode changes > server: pbs-client: check and fallback to PBS v3 ticket compat mode > Revert "ui: add wizard: note that login currently only works for PBS > 4" > > server/src/connection.rs | 31 +++++++++++++++++++----------- > ui/src/remotes/wizard_page_info.rs | 15 --------------- > 2 files changed, 20 insertions(+), 26 deletions(-) > > > Summary over all repositories: > 5 files changed, 65 insertions(+), 50 deletions(-) > > -- > Generated by git-murpp 0.8.1 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel