From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id BCE481FF187
	for <inbox@lore.proxmox.com>; Mon, 25 Aug 2025 11:56:09 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 2E5B7E45F;
	Mon, 25 Aug 2025 11:56:14 +0200 (CEST)
Message-ID: <5636a6b0-c11f-49fc-92d2-9a6b3829b2dc@proxmox.com>
Date: Mon, 25 Aug 2025 11:55:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox Datacenter Manager development discussion
 <pdm-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com>
References: <20250825081042.797559-1-d.csapak@proxmox.com>
 <20250825081042.797559-2-d.csapak@proxmox.com>
Content-Language: en-US
From: Stefan Hanreich <s.hanreich@proxmox.com>
In-Reply-To: <20250825081042.797559-2-d.csapak@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.710 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pdm-devel] [PATCH datacenter-manager v3 1/8] server: task
 cache: treat a limit of 0 as unbounded
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
 <pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>, 
 <mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>, 
 <mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
 <pdm-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>



On 8/25/25 10:10 AM, Dominik Csapak wrote:
> like we do in our other products e.g. like PBS
> This way, one can specify a way to return *all* tasks.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  server/src/remote_tasks/mod.rs | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/server/src/remote_tasks/mod.rs b/server/src/remote_tasks/mod.rs
> index 63a279a..91b79c1 100644
> --- a/server/src/remote_tasks/mod.rs
> +++ b/server/src/remote_tasks/mod.rs
> @@ -36,6 +36,11 @@ pub async fn get_tasks(filters: TaskFilters) -> Result<Vec<TaskListItem>, Error>
>              GetTasks::All
>          };
>  
> +        let limit = match filters.limit {
> +            0 => usize::MAX,
> +            limit => limit as usize,
> +        };
> +

is this a usize because of backwards / API compatibility? Otherwise,
wouldn't an Option be preferrable?

>          let returned_tasks = cache
>              .get_tasks(which)?
>              .filter_map(|task| {
> @@ -105,7 +110,7 @@ pub async fn get_tasks(filters: TaskFilters) -> Result<Vec<TaskListItem>, Error>
>                  true
>              })
>              .skip(filters.start as usize)
> -            .take(filters.limit as usize)
> +            .take(limit)
>              .collect();
>  
>          Ok(returned_tasks)



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel