From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 33B0C1FF15C for ; Wed, 5 Feb 2025 16:46:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 98623F2FD; Wed, 5 Feb 2025 16:46:48 +0100 (CET) Message-ID: <4c3a09b4-840a-40c6-b695-4c6eeb69eeda@proxmox.com> Date: Wed, 5 Feb 2025 16:46:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Datacenter Manager development discussion , Maximiliano Sandoval References: <20250114094828.119472-1-m.sandoval@proxmox.com> Content-Language: en-GB, de-AT From: Thomas Lamprecht Autocrypt: addr=t.lamprecht@proxmox.com; keydata= xsFNBFsLjcYBEACsaQP6uTtw/xHTUCKF4VD4/Wfg7gGn47+OfCKJQAD+Oyb3HSBkjclopC5J uXsB1vVOfqVYE6PO8FlD2L5nxgT3SWkc6Ka634G/yGDU3ZC3C/7NcDVKhSBI5E0ww4Qj8s9w OQRloemb5LOBkJNEUshkWRTHHOmk6QqFB/qBPW2COpAx6oyxVUvBCgm/1S0dAZ9gfkvpqFSD 90B5j3bL6i9FIv3YGUCgz6Ue3f7u+HsEAew6TMtlt90XV3vT4M2IOuECG/pXwTy7NtmHaBQ7 UJBcwSOpDEweNob50+9B4KbnVn1ydx+K6UnEcGDvUWBkREccvuExvupYYYQ5dIhRFf3fkS4+ wMlyAFh8PQUgauod+vqs45FJaSgTqIALSBsEHKEs6IoTXtnnpbhu3p6XBin4hunwoBFiyYt6 YHLAM1yLfCyX510DFzX/Ze2hLqatqzY5Wa7NIXqYYelz7tXiuCLHP84+sV6JtEkeSUCuOiUY virj6nT/nJK8m0BzdR6FgGtNxp7RVXFRz/+mwijJVLpFsyG1i0Hmv2zTn3h2nyGK/I6yhFNt dX69y5hbo6LAsRjLUvZeHXpTU4TrpN/WiCjJblbj5um5eEr4yhcwhVmG102puTtuCECsDucZ jpKpUqzXlpLbzG/dp9dXFH3MivvfuaHrg3MtjXY1i+/Oxyp5iwARAQABzTNUaG9tYXMgTGFt cHJlY2h0IChBdXRoLTQpIDx0LmxhbXByZWNodEBwcm94bW94LmNvbT7CwY4EEwEIADgWIQQO R4qbEl/pah9K6VrTZCM6gDZWBgUCWwuNxgIbAwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAK CRDTZCM6gDZWBm/jD/4+6JB2s67eaqoP6x9VGaXNGJPCscwzLuxDTCG90G9FYu29VcXtubH/ bPwsyBbNUQpqTm/s4XboU2qpS5ykCuTjqavrcP33tdkYfGcItj2xMipJ1i3TWvpikQVsX42R G64wovLs/dvpTYphRZkg5DwhgTmy3mRkmofFCTa+//MOcNOORltemp984tWjpR3bUJETNWpF sKGZHa3N4kCNxb7A+VMsJZ/1gN3jbQbQG7GkJtnHlWkw9rKCYqBtWrnrHa4UAvSa9M/XCIAB FThFGqZI1ojdVlv5gd6b/nWxfOPrLlSxbUo5FZ1i/ycj7/24nznW1V4ykG9iUld4uYUY86bB UGSjew1KYp9FmvKiwEoB+zxNnuEQfS7/Bj1X9nxizgweiHIyFsRqgogTvLh403QMSGNSoArk tqkorf1U+VhEncIn4H3KksJF0njZKfilrieOO7Vuot1xKr9QnYrZzJ7m7ZxJ/JfKGaRHXkE1 feMmrvZD1AtdUATZkoeQtTOpMu4r6IQRfSdwm/CkppZXfDe50DJxAMDWwfK2rr2bVkNg/yZI tKLBS0YgRTIynkvv0h8d9dIjiicw3RMeYXyqOnSWVva2r+tl+JBaenr8YTQw0zARrhC0mttu cIZGnVEvQuDwib57QLqMjQaC1gazKHvhA15H5MNxUhwm229UmdH3KM7BTQRbC43GARAAyTkR D6KRJ9Xa2fVMh+6f186q0M3ni+5tsaVhUiykxjsPgkuWXWW9MbLpYXkzX6h/RIEKlo2BGA95 QwG5+Ya2Bo3g7FGJHAkXY6loq7DgMp5/TVQ8phsSv3WxPTJLCBq6vNBamp5hda4cfXFUymsy HsJy4dtgkrPQ/bnsdFDCRUuhJHopnAzKHN8APXpKU6xV5e3GE4LwFsDhNHfH/m9+2yO/trcD txSFpyftbK2gaMERHgA8SKkzRhiwRTt9w5idOfpJVkYRsgvuSGZ0pcD4kLCOIFrer5xXudk6 NgJc36XkFRMnwqrL/bB4k6Pi2u5leyqcXSLyBgeHsZJxg6Lcr2LZ35+8RQGPOw9C0ItmRjtY ZpGKPlSxjxA1WHT2YlF9CEt3nx7c4C3thHHtqBra6BGPyW8rvtq4zRqZRLPmZ0kt/kiMPhTM 8wZAlObbATVrUMcZ/uNjRv2vU9O5aTAD9E5r1B0dlqKgxyoImUWB0JgpILADaT3VybDd3C8X s6Jt8MytUP+1cEWt9VKo4vY4Jh5vwrJUDLJvzpN+TsYCZPNVj18+jf9uGRaoK6W++DdMAr5l gQiwsNgf9372dbMI7pt2gnT5/YdG+ZHnIIlXC6OUonA1Ro/Itg90Q7iQySnKKkqqnWVc+qO9 GJbzcGykxD6EQtCSlurt3/5IXTA7t6sAEQEAAcLBdgQYAQgAIBYhBA5HipsSX+lqH0rpWtNk IzqANlYGBQJbC43GAhsMAAoJENNkIzqANlYGD1sP/ikKgHgcspEKqDED9gQrTBvipH85si0j /Jwu/tBtnYjLgKLh2cjv1JkgYYjb3DyZa1pLsIv6rGnPX9bH9IN03nqirC/Q1Y1lnbNTynPk IflgvsJjoTNZjgu1wUdQlBgL/JhUp1sIYID11jZphgzfDgp/E6ve/8xE2HMAnf4zAfJaKgD0 F+fL1DlcdYUditAiYEuN40Ns/abKs8I1MYx7Yglu3RzJfBzV4t86DAR+OvuF9v188WrFwXCS RSf4DmJ8tntyNej+DVGUnmKHupLQJO7uqCKB/1HLlMKc5G3GLoGqJliHjUHUAXNzinlpE2Vj C78pxpwxRNg2ilE3AhPoAXrY5qED5PLE9sLnmQ9AzRcMMJUXjTNEDxEYbF55SdGBHHOAcZtA kEQKub86e+GHA+Z8oXQSGeSGOkqHi7zfgW1UexddTvaRwE6AyZ6FxTApm8wq8NT2cryWPWTF BDSGB3ujWHMM8ERRYJPcBSjTvt0GcEqnd+OSGgxTkGOdufn51oz82zfpVo1t+J/FNz6MRMcg 8nEC+uKvgzH1nujxJ5pRCBOquFZaGn/p71Yr0oVitkttLKblFsqwa+10Lt6HBxm+2+VLp4Ja 0WZNncZciz3V3cuArpan/ZhhyiWYV5FD0pOXPCJIx7WS9PTtxiv0AOS4ScWEUmBxyhFeOpYa DrEx In-Reply-To: <20250114094828.119472-1-m.sandoval@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.442 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_ASCII_DIVIDERS 0.8 Email that uses ascii formatting dividers and possible spam tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [types.rs, mod.rs] Subject: Re: [pdm-devel] [PATCH proxmox-api-types] docs: escape HTML delimiters X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Am 14.01.25 um 10:48 schrieb Maximiliano Sandoval: > Fixes: > > $ cargo doc --all-features --workspace > warning: unresolved link to `acdn` > --> pve-api-types/src/types/../generated/types.rs:3780:5 > | > 3780 | / /// The guest will attempt to boot from devices in the order they appear > 3781 | | /// here. > 3782 | | /// > 3783 | | /// Disks, optical drives and passed-through storage USB devices will be > ... | > 3792 | | /// > 3793 | | /// Overrides the deprecated 'legacy=[acdn]*' value when given. > | |___________________________________________________________________^ > | > = note: the link appears in this line: > > Overrides the deprecated 'legacy=[acdn]*' value when given. > ^^^^ > = note: no item named `acdn` in scope > = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]` > = note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default > > warning: unclosed HTML tag `nodename` > --> pve-api-types/src/types/../generated/types.rs:272:5 > | > 272 | / /// Unique identifier for this metric object, for instance 'node/' > 273 | | /// or 'qemu/'. > | |_________________________^ > | > = note: `#[warn(rustdoc::invalid_html_tags)]` on by default > > warning: unclosed HTML tag `vmid` > --> pve-api-types/src/types/../generated/types.rs:272:5 > | > 272 | / /// Unique identifier for this metric object, for instance 'node/' > 273 | | /// or 'qemu/'. > | |_________________________^ > > warning: unclosed HTML tag `ostype` > --> pve-api-types/src/types/../generated/types.rs:2061:1 > | > 2061 | / /// OS type. This is used to setup configuration inside the container, and > 2062 | | /// corresponds to lxc setup scripts in > 2063 | | /// /usr/share/lxc/config/.common.conf. Value 'unmanaged' can be used to > 2064 | | /// skip and OS specific setup. > | |_______________________________^ > > warning: unclosed HTML tag `type` > --> pve-api-types/src/client/mod.rs:35:10 > | > 35 | /// For "-list" entries we turn an array into a string ready for perl's `split_list()` call. tbh. I'm not a big fan of having the full error output in the commit message for these type of commits, this is a lot of noise without much extra value. Should be enough to just list the warning names it fixes, maybe with the short description. One can then check the full error for oneself by compiling the state before this, or search for the warning name to get all details. > > Signed-off-by: Maximiliano Sandoval > --- > pve-api-types/src/client/mod.rs | 2 +- > pve-api-types/src/generated/types.rs | 8 ++++---- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/pve-api-types/src/client/mod.rs b/pve-api-types/src/client/mod.rs > index 8832272..0de7cc3 100644 > --- a/pve-api-types/src/client/mod.rs > +++ b/pve-api-types/src/client/mod.rs > @@ -32,7 +32,7 @@ pub fn add_query_bool(query: &mut String, separator: &mut char, name: &str, valu > } > } > > -/// For "-list" entries we turn an array into a string ready for perl's `split_list()` call. > +/// For `-list` entries we turn an array into a string ready for perl's `split_list()` call. this hunks seems all right, but the ones below are in generated code, so was the source that produced this error updated already and this is only refreshing the generated code or is that still missing? > pub fn add_query_arg_string_list( > query: &mut String, > separator: &mut char, > diff --git a/pve-api-types/src/generated/types.rs b/pve-api-types/src/generated/types.rs > index b6a3d20..0532dc6 100644 > --- a/pve-api-types/src/generated/types.rs > +++ b/pve-api-types/src/generated/types.rs > @@ -269,8 +269,8 @@ pub struct ClusterMetrics { > /// Object. > #[derive(Debug, serde::Deserialize, serde::Serialize)] > pub struct ClusterMetricsData { > - /// Unique identifier for this metric object, for instance 'node/' > - /// or 'qemu/'. > + /// Unique identifier for this metric object, for instance `node/` > + /// or `qemu/`. > pub id: String, > > /// Name of the metric. > @@ -2174,7 +2174,7 @@ serde_plain::derive_fromstr_from_deserialize!(LxcConfigNetType); > #[api] > /// OS type. This is used to setup configuration inside the container, and > /// corresponds to lxc setup scripts in > -/// /usr/share/lxc/config/.common.conf. Value 'unmanaged' can be used to > +/// `/usr/share/lxc/config/.common.conf`. Value 'unmanaged' can be used to > /// skip and OS specific setup. > #[derive(Clone, Copy, Debug, Eq, PartialEq, serde::Deserialize, serde::Serialize)] > pub enum LxcConfigOstype { > @@ -3910,7 +3910,7 @@ pub struct PveQmBoot { > /// disks for booting (e.g. software-raid), you need to specify all of > /// them here. > /// > - /// Overrides the deprecated 'legacy=[acdn]*' value when given. > + /// Overrides the deprecated `legacy=[acdn]*` value when given. > #[serde(default, skip_serializing_if = "Option::is_none")] > pub order: Option, > } _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel