From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DD7791FF141 for ; Mon, 16 Mar 2026 14:42:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 59A521B4F0; Mon, 16 Mar 2026 14:42:32 +0100 (CET) Date: Mon, 16 Mar 2026 14:42:26 +0100 From: Arthur Bied-Charreton To: Lukas Wagner Subject: Re: [PATCH datacenter-manager/proxmox{,-backup,-yew-comp} 00/26] metric collection for the PDM host Message-ID: <3eovhoenhjowobftwr425s2q62nitqe4cpdwoxqs33hp4kh6lq@qxmldrdetrrd> References: <20260312135229.420729-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260312135229.420729-1-l.wagner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773668507191 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.264 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KAVNSBIIEHZBTRE7IN3T7NKEWAIBAHKL X-Message-ID-Hash: KAVNSBIIEHZBTRE7IN3T7NKEWAIBAHKL X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pdm-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Mar 12, 2026 at 02:52:01PM +0100, Lukas Wagner wrote: > This series add metric collection physical PDM hosts. > > The patches for `proxmox` introduce three new crates: > - proxmox-disks: broken out from proxmox-backup, needed to read disk stats > - proxmox-parallel-handler: also broken out from proxmox-backup, > needed as a dependency for proxmox-disks. Since the scope was manageable, > this series improves the existing code a bit by adding a dedicated error type, > some documentation and basic unit tests > - proxmox-procfs: as a new home for any procfs related modules. this patch series adds > a `pressure` module for reading pressure stall information for the host and cgroups. > The general idea is that we should move other procfs helpers from proxmox-sys into > this new crate, but to avoid scope explosion this is not done as a part of this > series > > The patches for proxmox-backup just switch over to the new moved implementations of proxmox-disks > and proxmox-parallel-handler. > > The patches for proxmox-yew-comp slight adapt the existing NodeStatusPanel to allow the application > to inject child components into the same panel. > > The proxmox-datacenter-manager patches do some initial refactoring (naming), and then add the needed > collection loop, API types and UI elements. [...] Looks very nice, gave this a spin on my PDM VM, everything works, the metrics are being collected & updated, and they are consistent with what I see on my machine. Responded to some patches directly with some comments, modulo that consider this series: Reviewed-by: Arthur Bied-Charreton Tested-by: Arthur Bied-Charreton