From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pdm-devel] applied: [PATCH datacenter-manager] remove 'per-node-template' from the weburl config
Date: Sat, 25 Jan 2025 18:01:04 +0100 [thread overview]
Message-ID: <37c5c22c-a6e8-4130-a0e9-d3741907a1ef@proxmox.com> (raw)
In-Reply-To: <20250123132754.3271555-1-d.csapak@proxmox.com>
Am 23.01.25 um 14:27 schrieb Dominik Csapak:
> * remove the property from the struct
> * remove the second edit field
> * adapt url generation code
>
> i left the 'node' parameter in the 'get_deep_url' since we'll want to
> add it later again (does not hurt to not use it), but removed the option
> from the config again, otherwise a user might set it and wonders why it
> doesn't to anything.
yeah, not sure about the config layout (now or final) for this, but it's
fine enough for now I think.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> lib/pdm-api-types/src/remotes.rs | 4 ---
> ui/src/lib.rs | 50 +++++++++++++-------------------
> ui/src/remotes/edit_remote.rs | 19 ------------
> 3 files changed, 20 insertions(+), 53 deletions(-)
>
>
applied, thanks!
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2025-01-25 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 13:27 [pdm-devel] " Dominik Csapak
2025-01-25 17:01 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37c5c22c-a6e8-4130-a0e9-d3741907a1ef@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox