From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 185881FF16B
for <inbox@lore.proxmox.com>; Thu, 20 Mar 2025 09:11:03 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 480DB1EDD5;
Thu, 20 Mar 2025 09:11:03 +0100 (CET)
Message-ID: <2b0f5897-3728-4f11-bf8f-2dec4dd2110a@proxmox.com>
Date: Thu, 20 Mar 2025 09:10:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Dietmar Maurer <dietmar@proxmox.com>,
Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
References: <20250318143252.3531503-1-d.csapak@proxmox.com>
<20250318143252.3531503-2-d.csapak@proxmox.com>
<1795082062.588.1742451918868@webmail.proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <1795082062.588.1742451918868@webmail.proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.022 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [proxmox.com, tasks.rs]
Subject: Re: [pdm-devel] [PATCH yew-comp 1/2] tasks: don't mark running
tasks from pve with 'error' color
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
<pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>
On 3/20/25 07:25, Dietmar Maurer wrote:
>> running tasks from the PVE tasks API have 'RUNNING' in their status
>> field (in contrast to e.g. the PBS API) instead of nothing.
>
> Instead of nothing?
>
> Would it be more clear to use:
>
> if !(status == "OK" /* PBS */ || status == "RUNNING" /* PVE */)) {
>
> }
yeah looks fine to me too
alternatively we could maybe do (untested):
match status {
"RUNNING" | "OK" => {},
status if status.starts_with("WARNINGS:") => { .. warning .. }
_ => { .. error .. }
}
>
>> To not mark
>> them with an error color, we have to make an exception for this here.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> src/tasks.rs | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/tasks.rs b/src/tasks.rs
>> index 1b65c8e..499f5b9 100644
>> --- a/src/tasks.rs
>> +++ b/src/tasks.rs
>> @@ -172,7 +172,7 @@ impl LoadableComponent for ProxmoxTasks {
>> if status != "OK" {
>> if status.starts_with("WARNINGS:") {
>> args.add_class("pwt-color-warning");
>> - } else {
>> + } else if status != "RUNNING" {
>> args.add_class("pwt-color-error");
>> }
>> }
>> --
>> 2.39.5
>>
>>
>>
>> _______________________________________________
>> pdm-devel mailing list
>> pdm-devel@lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel