From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 00A471FF09C for ; Mon, 05 Oct 2026 09:10:11 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 80BCF213A5; Mon, 05 Oct 2026 09:10:11 +0200 (CEST) Message-ID: <29f5eef5-1147-45ca-a921-8bb554278ac1@proxmox.com> Date: Mon, 5 Oct 2026 09:09:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH datacenter-manager v5 00/10] refactor and partially fix #7371 From: Dominik Csapak To: pdm-devel@lists.proxmox.com References: <20261002141448.3336388-1-d.csapak@proxmox.com> Content-Language: en-US In-Reply-To: <20261002141448.3336388-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791184205500 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.406 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: U4U5XQYWPLFWBMMBDU23UOQQ5K3NFR7H X-Message-ID-Hash: U4U5XQYWPLFWBMMBDU23UOQQ5K3NFR7H X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: FYI: this version has a bug that the tags are shown double in the resource tree. (this could be a fixup or i can send a new version depending on the remaining review) On 10/2/26 4:15 PM, Dominik Csapak wrote: > the first 6 patches are pure refactors and should not change anything > user visible, could be applied independently. > > patch 7,8,10 partially fix #7371 by showing the HA maintenance status > of PVE nodes in various places. > > patch 9 is just a fix that came up (thanks @lukas) > > NOTE: requires my recent tree view patches[0] applied first > > changes from v4: > * rebase on master and on [0] > > chagnes from v3: > * rebase on master > * add serde skip_serialize_if for option none on the ha maintenance field > * added new patch for sorting by memory usage correctly > > changes from v2: > * add missing doc comments > * refine wording a bit and make it more consistent (HA -> ha for example) > * change from string 'hastate' to proper rust enum 'ha-state' in > PveNodeResource struct > > changes from v1: > * fixed some display problems: NaN% when maxmem was set to 0.0, > 0.0% cpu when the node was offline, fixed by not showing values for > offline nodes > * add a new patch for showing tha badge too in the node card's title > * various typo fixes > * added #[serde(default)] to the new hastate field to allow > deserialization from older versions > * some smaller fixes (left over comments, naming, etc.) > > 0: https://lore.proxmox.com/pdm-devel/20261002135324.3147672-1-d.csapak@proxmox.com/T/#t > > Dominik Csapak (10): > lib: api types: add new ResourceView type and move accessors there > lib: api types: resource: add 'node' helper to ResourceView > lib: api types: add guest specific getter to ResourceView > ui: pve: factor out the pve-manager version extraction > ui: renderer: use ResourceView for rendering > ui: pve: tree: reuse `PveResource` for `PveTreeNode` > ui: pve: show ha maintenance mode for nodes > ui: pve: node selector: show maintenance badge with node name > ui: pve: node selector: sort memory columns by usage not by memory > size > ui: pve: node: show ha maintenance badge > > lib/pdm-api-types/src/resource.rs | 336 ++++++++++++++++++++++------- > server/src/api/resources.rs | 1 + > ui/pwt-assets | 2 +- > ui/src/dashboard/top_entities.rs | 5 +- > ui/src/guests.rs | 6 +- > ui/src/lib.rs | 23 +- > ui/src/pve/mod.rs | 73 ++++--- > ui/src/pve/node/mod.rs | 15 +- > ui/src/pve/tree.rs | 298 ++++++++++++------------- > ui/src/renderer.rs | 80 ++++--- > ui/src/widget/pve_node_selector.rs | 95 +++++--- > ui/src/widget/resource_tree.rs | 11 +- > 12 files changed, 576 insertions(+), 369 deletions(-) >