public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: Erik Fastermann <e.fastermann@proxmox.com>,
	pbs-devel@lists.proxmox.com, pdm-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup v2 2/5] d/control: depend on tools used by the system report
Date: Mon, 10 Aug 2026 14:30:05 +0200	[thread overview]
Message-ID: <2283203b-3ea9-4bf8-8575-390758a07472@proxmox.com> (raw)
In-Reply-To: <20260730101349.217371-3-e.fastermann@proxmox.com>

On 7/30/26 12:13 PM, Erik Fastermann wrote:
> The report runs ethtool per physical interface, top (package procps)
> for the load section and proxmox-boot-tool (package
> proxmox-kernel-helper) for the ESP status, none of which were depended
> on directly.
> 
> proxmox-kernel-helper is a recommendation rather than a direct
> dependency, as proxmox-boot-tool is not required on systems which are
> not running a Proxmox kernel.
> 
> Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
> ---
>   debian/control | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/debian/control b/debian/control
> index 1ddb7c481..2ef403a7b 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -199,6 +199,7 @@ Rules-Requires-Root: binary-targets
>   Package: proxmox-backup-server
>   Architecture: any
>   Depends: dmidecode,
> +         ethtool,
>            fonts-font-awesome,
>            gdisk,
>            iproute2,
> @@ -212,6 +213,7 @@ Depends: dmidecode,
>            pbs-i18n,
>            pciutils,
>            postfix | mail-transport-agent,
> +         procps,
>            proxmox-backup-docs,
>            proxmox-enterprise-support-keyring,
>            proxmox-mini-journalreader (>= 1.7),
> @@ -223,6 +225,7 @@ Depends: dmidecode,
>            ${misc:Depends},
>            ${shlibs:Depends},
>   Recommends: ifupdown2,
> +            proxmox-kernel-helper,
>               proxmox-mail-forward,
>               proxmox-network-interface-pinning,
>               proxmox-offline-mirror-helper,

needs a rebase




  reply	other threads:[~2026-08-10 12:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30 10:13 [PATCH proxmox{,-backup,-datacenter-manager} v2 0/5] factor system report into shared crate Erik Fastermann
2026-07-30 10:13 ` [PATCH proxmox v2 1/5] system-report: add crate for shared report generation Erik Fastermann
2026-08-10 12:28   ` Christian Ebner
2026-07-30 10:13 ` [PATCH proxmox-backup v2 2/5] d/control: depend on tools used by the system report Erik Fastermann
2026-08-10 12:30   ` Christian Ebner [this message]
2026-07-30 10:13 ` [PATCH proxmox-backup v2 3/5] report: use shared proxmox-system-report crate Erik Fastermann
2026-07-30 10:13 ` [PATCH proxmox-datacenter-manager v2 4/5] d/control: depend on tools used by the system report Erik Fastermann
2026-07-30 10:13 ` [PATCH proxmox-datacenter-manager v2 5/5] report: use shared proxmox-system-report crate Erik Fastermann
2026-07-30 10:18 ` [PATCH proxmox{,-backup,-datacenter-manager} v2 0/5] factor system report into shared crate Erik Fastermann
2026-08-10 12:47 ` Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2283203b-3ea9-4bf8-8575-390758a07472@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=e.fastermann@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal