From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id CAA6E1FF16B
for <inbox@lore.proxmox.com>; Thu, 20 Mar 2025 10:08:14 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id E5B593030D;
Thu, 20 Mar 2025 10:08:14 +0100 (CET)
Date: Thu, 20 Mar 2025 10:08:12 +0100 (CET)
From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com>
Message-ID: <2052623329.647.1742461692510@webmail.proxmox.com>
In-Reply-To: <20250318143252.3531503-3-d.csapak@proxmox.com>
References: <20250318143252.3531503-1-d.csapak@proxmox.com>
<20250318143252.3531503-3-d.csapak@proxmox.com>
MIME-Version: 1.0
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.6-Rev74
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.329 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [tasks.rs]
Subject: Re: [pdm-devel] [PATCH yew-comp 2/2] tasks: add loading animation
for running tasks
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
<pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>
comments inline
> On 18.3.2025 15:32 CET Dominik Csapak <d.csapak@proxmox.com> wrote:
>
>
> when there is no endtime and the status is either empty or "RUNNING"
> (for PVE), render a spinning loading icon, like we do in the ExtJS UI.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/tasks.rs | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/src/tasks.rs b/src/tasks.rs
> index 499f5b9..1d3b0bf 100644
> --- a/src/tasks.rs
> +++ b/src/tasks.rs
> @@ -17,7 +17,7 @@ use pwt::state::{PersistentState, Selection, Store};
> use pwt::widget::data_table::{
> DataTable, DataTableColumn, DataTableHeader, DataTableRowRenderCallback,
> };
> -use pwt::widget::{Button, Column, Toolbar};
> +use pwt::widget::{Button, Column, Fa, Row, Toolbar};
>
> use crate::utils::{format_upid, render_epoch_short};
>
> @@ -122,7 +122,11 @@ impl ProxmoxTasks {
> .width("130px")
> .render(|item: &TaskListItem| match item.endtime {
> Some(endtime) => render_epoch_short(endtime).into(),
> - None => html! {},
> + None => Row::new()
> + .with_flex_spacer()
> + .with_child(Fa::new("").class("pwt-loading-icon"))
> + .with_flex_spacer()
> + .into(),
Don't we have a simpler way to center things? RTow is a flex layout,
so you can easily center children.
> })
> .into(),
> DataTableColumn::new(tr!("User name"))
> @@ -139,7 +143,14 @@ impl ProxmoxTasks {
> .width("200px")
> .render(|item: &TaskListItem| {
> let text = item.status.as_deref().unwrap_or("");
> - html! {text}
> + match text {
> + "" | "RUNNING" => Row::new()
> + .with_flex_spacer()
> + .with_child(Fa::new("").class("pwt-loading-icon"))
> + .with_flex_spacer()
> + .into(),
> + text => html! {text},
> + }
match should be one level above...
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel