From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 1503A1FF0AB for ; Wed, 07 Oct 2026 09:45:45 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E1BE02131A; Wed, 07 Oct 2026 09:45:41 +0200 (CEST) From: Thomas Ellmenreich To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager 5/6] api: set REST server debug level based on actual log level Date: Wed, 7 Oct 2026 09:45:14 +0200 Message-ID: <20261007074527.102419-6-t.ellmenreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261007074527.102419-1-t.ellmenreich@proxmox.com> References: <20261007074527.102419-1-t.ellmenreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791359136715 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.459 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3ZGXZWMQCREEWXPFQFBIV736O4LWYZCA X-Message-ID-Hash: 3ZGXZWMQCREEWXPFQFBIV736O4LWYZCA X-MailFrom: t.ellmenreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Thomas Ellmenreich X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Use the configuration returned by the initialised logger to decide whether to activate debugging for the REST server. Previously, whether the REST server was in debug mode would only be determined by the existence of the PROXMOX_DEBUG variable, regardless of its value. Now, if the environment variable is set to a less verbose level than 'debug', the REST server will not activate its debug level. Signed-off-by: Thomas Ellmenreich --- server/src/bin/proxmox-datacenter-api/main.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/server/src/bin/proxmox-datacenter-api/main.rs b/server/src/bin/proxmox-datacenter-api/main.rs index 57aa6e22..2fc84c1d 100644 --- a/server/src/bin/proxmox-datacenter-api/main.rs +++ b/server/src/bin/proxmox-datacenter-api/main.rs @@ -17,6 +17,7 @@ use tracing::level_filters::LevelFilter; use url::form_urlencoded; use proxmox_lang::try_block; +use proxmox_log::Level; use proxmox_rest_server::{ApiConfig, RestEnvironment, RestServer}; use proxmox_router::{RpcEnvironment, RpcEnvironmentType}; use proxmox_sys::fs::CreateOptions; @@ -46,13 +47,13 @@ fn main() -> Result<(), Error> { server::env::sanitize_environment_vars(); - let debug = std::env::var("PROXMOX_DEBUG").is_ok(); - proxmox_log::Logger::from_env("PROXMOX_DEBUG", LevelFilter::INFO) .journald_on_no_workertask() .tasklog_pbs() .init()?; + let debug = proxmox_log::enabled!(Level::DEBUG); + if std::env::args().nth(1).is_some() { bail!("unexpected command line parameters"); } -- 2.47.3