From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 44BF41FF09C for ; Mon, 05 Oct 2026 13:00:57 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7BD75215A1; Mon, 05 Oct 2026 13:00:54 +0200 (CEST) From: Dominik Csapak To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager v6 00/11] refactor and partially fix #7371 Date: Mon, 5 Oct 2026 12:57:27 +0200 Message-ID: <20261005110049.1851404-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.403 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: O5WMHDWGACSTVIBFT6UMIWL7SPOYTRIM X-Message-ID-Hash: O5WMHDWGACSTVIBFT6UMIWL7SPOYTRIM X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: the first 6 patches are pure refactors and should not change anything user visible, could be applied independently. patch 7 is to slightly change the columns for the pve tree (put the tags with the names instead of a separate column) patch 8,9,11 partially fix #7371 by showing the HA maintenance status of PVE nodes in various places. patch 10 is just a fix that came up (thanks @lukas) NOTE: This incorporates 1/2 from [0] so this series is self contained (i'll send a new version of 2/2 from that in a different series) changes from v5: * rebase on master * move pve tree tags patch after the refactor, before the ha maintenance fix changes from v4: * rebase on master and on [0] chagnes from v3: * rebase on master * add serde skip_serialize_if for option none on the ha maintenance field * added new patch for sorting by memory usage correctly changes from v2: * add missing doc comments * refine wording a bit and make it more consistent (HA -> ha for example) * change from string 'hastate' to proper rust enum 'ha-state' in PveNodeResource struct changes from v1: * fixed some display problems: NaN% when maxmem was set to 0.0, 0.0% cpu when the node was offline, fixed by not showing values for offline nodes * add a new patch for showing tha badge too in the node card's title * various typo fixes * added #[serde(default)] to the new hastate field to allow deserialization from older versions * some smaller fixes (left over comments, naming, etc.) 0: https://lore.proxmox.com/pdm-devel/20261002135324.3147672-1-d.csapak@proxmox.com/T/#t Dominik Csapak (11): lib: api types: add new ResourceView type and move accessors there lib: api types: resource: add 'node' helper to ResourceView lib: api types: add guest specific getter to ResourceView ui: pve: factor out the pve-manager version extraction ui: renderer: use ResourceView for rendering ui: pve: tree: reuse `PveResource` for `PveTreeNode` ui: pve: tree: render guest tags directly after their name ui: pve: show ha maintenance mode for nodes ui: pve: node selector: show maintenance badge with node name ui: pve: node selector: sort memory columns by usage not by memory size ui: pve: node: show ha maintenance badge lib/pdm-api-types/src/resource.rs | 336 ++++++++++++++++++++++------- server/src/api/resources.rs | 1 + ui/css/pdm.scss | 3 + ui/pwt-assets | 2 +- ui/src/dashboard/top_entities.rs | 5 +- ui/src/guests.rs | 6 +- ui/src/lib.rs | 23 +- ui/src/pve/mod.rs | 73 ++++--- ui/src/pve/node/mod.rs | 15 +- ui/src/pve/tree.rs | 305 ++++++++++++-------------- ui/src/pve/utils.rs | 6 +- ui/src/renderer.rs | 72 ++++--- ui/src/widget/pve_node_selector.rs | 95 +++++--- ui/src/widget/resource_tree.rs | 17 +- 14 files changed, 580 insertions(+), 379 deletions(-) -- 2.47.3