From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 192641FF0B7 for ; Fri, 02 Oct 2026 15:53:30 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 99193216A3; Fri, 02 Oct 2026 15:53:29 +0200 (CEST) From: Dominik Csapak To: pdm-devel@lists.proxmox.com Subject: [RFC PATCH datacenter-manager 2/2] ui: pve: tree: size action column better Date: Fri, 2 Oct 2026 15:50:41 +0200 Message-ID: <20261002135324.3147672-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261002135324.3147672-1-d.csapak@proxmox.com> References: <20261002135324.3147672-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.420 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FLTQIYQ7OXLS4HBJ5F4IM55O5BDLTNCD X-Message-ID-Hash: FLTQIYQ7OXLS4HBJ5F4IM55O5BDLTNCD X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: instead of using a fixed pixel size. While the new expression looks ugly, that is the exact size needed to show all action columns in all density variants. Ideally we'd have a way to automatically size a column by it's content (in a buffered grid), but until we implement such a thing, this should be ok. Signed-off-by: Dominik Csapak --- meh, i don't like either the before nor the after. I have some ideas how we could make this work on the datatable side in a generic way, but this is rather involved, and i'm not sure if it's worth it to spend much time on it when we can do it like this. ui/src/pve/tree.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/src/pve/tree.rs b/ui/src/pve/tree.rs index 2faa4349..6cac96fa 100644 --- a/ui/src/pve/tree.rs +++ b/ui/src/pve/tree.rs @@ -645,7 +645,7 @@ fn columns( }) .into(), DataTableColumn::new(tr!("Actions")) - .width("180px") + .width("calc(4 * (20px + 2* var(--pwt-spacer-1)) + 2 * var(--pwt-spacer-2))") .render(move |entry: &PveTreeNode| { let (id, local_id, guest_info, node) = match entry { PveTreeNode::Lxc(r) => { -- 2.47.3