public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH datacenter-manager v4 00/10] refactor and partially fix #7371
Date: Wed, 23 Sep 2026 15:17:00 +0200	[thread overview]
Message-ID: <20260923131857.2953139-1-d.csapak@proxmox.com> (raw)

the first 6 patches are pure refactors and should not change anything
user visible, could be applied independently.

patch 7,8,10 partially fix #7371 by showing the HA maintenance status
of PVE nodes in various places.

patch 9 is just a fix that came up  (thanks @lukas)

chagnes from v3:
* rebase on master
* add serde skip_serialize_if for option none on the ha maintenance field
* added new patch for sorting by memory usage correctly

changes from v2:
* add missing doc comments
* refine wording a bit and make it more consistent (HA -> ha for example)
* change from string 'hastate' to proper rust enum 'ha-state' in
  PveNodeResource struct

changes from v1:
* fixed some display problems: NaN% when maxmem was set to 0.0,
  0.0% cpu when the node was offline, fixed by not showing values for
  offline nodes
* add a new patch for showing tha badge too in the node card's title
* various typo fixes
* added #[serde(default)] to the new hastate field to allow
  deserialization from older versions
* some smaller fixes  (left over comments, naming, etc.)


Dominik Csapak (10):
  lib: api types: add new ResourceView type and move accessors there
  lib: api types: resource: add 'node' helper to ResourceView
  lib: api types: add guest specific getter to ResourceView
  ui: pve: factor out the pve-manager version extraction
  ui: renderer: use ResourceView for rendering
  ui: pve: tree: reuse `PveResource` for `PveTreeNode`
  ui: pve: show ha maintenance mode for nodes
  ui: pve: node selector: show maintenance badge with node name
  ui: pve: node selector: sort memory columns by usage not by memory
    size
  ui: pve: node: show ha maintenance badge

 lib/pdm-api-types/src/resource.rs  | 336 ++++++++++++++++++++++-------
 server/src/api/resources.rs        |   1 +
 ui/pwt-assets                      |   2 +-
 ui/src/dashboard/top_entities.rs   |   5 +-
 ui/src/guests.rs                   |   6 +-
 ui/src/lib.rs                      |  23 +-
 ui/src/pve/mod.rs                  |  73 ++++---
 ui/src/pve/node/mod.rs             |  15 +-
 ui/src/pve/tree.rs                 | 302 ++++++++++++--------------
 ui/src/renderer.rs                 |  69 +++---
 ui/src/widget/pve_node_selector.rs |  95 +++++---
 ui/src/widget/resource_tree.rs     |  11 +-
 12 files changed, 575 insertions(+), 363 deletions(-)

-- 
2.47.3





             reply	other threads:[~2026-09-23 13:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 13:17 Dominik Csapak [this message]
2026-09-23 13:17 ` [PATCH datacenter-manager v4 01/10] lib: api types: add new ResourceView type and move accessors there Dominik Csapak
2026-09-23 13:17 ` [PATCH datacenter-manager v4 02/10] lib: api types: resource: add 'node' helper to ResourceView Dominik Csapak
2026-09-23 13:17 ` [PATCH datacenter-manager v4 03/10] lib: api types: add guest specific getter " Dominik Csapak
2026-09-23 13:17 ` [PATCH datacenter-manager v4 04/10] ui: pve: factor out the pve-manager version extraction Dominik Csapak
2026-09-23 13:17 ` [PATCH datacenter-manager v4 05/10] ui: renderer: use ResourceView for rendering Dominik Csapak
2026-09-23 13:17 ` [PATCH datacenter-manager v4 06/10] ui: pve: tree: reuse `PveResource` for `PveTreeNode` Dominik Csapak
2026-09-23 13:17 ` [PATCH datacenter-manager v4 07/10] ui: pve: show ha maintenance mode for nodes Dominik Csapak
2026-09-23 13:17 ` [PATCH datacenter-manager v4 08/10] ui: pve: node selector: show maintenance badge with node name Dominik Csapak
2026-09-23 13:17 ` [PATCH datacenter-manager v4 09/10] ui: pve: node selector: sort memory columns by usage not by memory size Dominik Csapak
2026-09-23 13:17 ` [PATCH datacenter-manager v4 10/10] ui: pve: node: show ha maintenance badge Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260923131857.2953139-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal