From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 0204F1FF09C for ; Mon, 21 Sep 2026 11:53:20 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3C0EC214F1; Mon, 21 Sep 2026 11:53:19 +0200 (CEST) From: Thomas Ellmenreich To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager 5/5] api: set REST server debug level based on actual log level Date: Mon, 21 Sep 2026 11:51:58 +0200 Message-ID: <20260921095210.229315-7-t.ellmenreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260921095210.229315-2-t.ellmenreich@proxmox.com> References: <20260921095210.229315-2-t.ellmenreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1789984393602 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.584 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZC4AY2UYCYFJ2Q4NG6CZPD7TJX6ZSCNS X-Message-ID-Hash: ZC4AY2UYCYFJ2Q4NG6CZPD7TJX6ZSCNS X-MailFrom: t.ellmenreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Thomas Ellmenreich X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Use the configuration returned by the initialised logger to decide whether to activate debugging for the REST server. Previously, whether the REST server was in debug mode would only be determined by the existence of the PROXMOX_DEBUG variable, regardless of its value. Now, if the environment variable is set to a less verbose level than 'debug', the REST server will not activate its debug level. Signed-off-by: Thomas Ellmenreich --- server/src/bin/proxmox-datacenter-api/main.rs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/server/src/bin/proxmox-datacenter-api/main.rs b/server/src/bin/proxmox-datacenter-api/main.rs index 57aa6e22..7b2d85cb 100644 --- a/server/src/bin/proxmox-datacenter-api/main.rs +++ b/server/src/bin/proxmox-datacenter-api/main.rs @@ -46,13 +46,15 @@ fn main() -> Result<(), Error> { server::env::sanitize_environment_vars(); - let debug = std::env::var("PROXMOX_DEBUG").is_ok(); - - proxmox_log::Logger::from_env("PROXMOX_DEBUG", LevelFilter::INFO) + let log_config = proxmox_log::Logger::from_env("PROXMOX_DEBUG", LevelFilter::INFO) .journald_on_no_workertask() .tasklog_pbs() .init()?; + // NOTE: this will now also activate if a very specific module is set + // to debug but the default level is still on info + let debug = log_config.global_filter_max_level_hint() >= LevelFilter::DEBUG; + if std::env::args().nth(1).is_some() { bail!("unexpected command line parameters"); } -- 2.47.3