public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH proxmox v3 0/2] check privilege paths during compilation
Date: Mon, 14 Sep 2026 14:30:43 +0200	[thread overview]
Message-ID: <20260914123243.3216993-1-d.csapak@proxmox.com> (raw)

This adds a check in proxmox-router to check the used parameter interpolations
in the privilege paths of api calls for existence.

changes from v2:
* rebase on master
* drop applied patch
* correctly check strings that are smaller than 3 characters
* also check UserParam and WithParam parameter for existence
* factor out byte slice compare check from proxmox-schema and use that
* add more tests

changes from rfc/v1:
* rebase on master
* require Resource.Audit on /resource/{remote} for each remote, filter out
  where this isn't the case instead of requiring it on /resource

Dominik Csapak (2):
  add proxmox-const-utils crate, factor out checks from proxmox-schema
  router: compile time check privilege path parameters for existence

 Cargo.toml                               |   2 +
 proxmox-const-utils/Cargo.toml           |  13 ++
 proxmox-const-utils/debian/changelog     |   5 +
 proxmox-const-utils/debian/control       |  30 +++
 proxmox-const-utils/debian/copyright     |  18 ++
 proxmox-const-utils/debian/debcargo.toml |   7 +
 proxmox-const-utils/src/lib.rs           |  66 +++++++
 proxmox-router/Cargo.toml                |   1 +
 proxmox-router/src/router.rs             | 235 ++++++++++++++++++++++-
 proxmox-schema/Cargo.toml                |   1 +
 proxmox-schema/src/const_test_utils.rs   |  25 ---
 proxmox-schema/src/lib.rs                |   2 -
 proxmox-schema/src/schema.rs             |  10 +-
 13 files changed, 382 insertions(+), 33 deletions(-)
 create mode 100644 proxmox-const-utils/Cargo.toml
 create mode 100644 proxmox-const-utils/debian/changelog
 create mode 100644 proxmox-const-utils/debian/control
 create mode 100644 proxmox-const-utils/debian/copyright
 create mode 100644 proxmox-const-utils/debian/debcargo.toml
 create mode 100644 proxmox-const-utils/src/lib.rs
 delete mode 100644 proxmox-schema/src/const_test_utils.rs

-- 
2.47.3





             reply	other threads:[~2026-09-14 12:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14 12:30 Dominik Csapak [this message]
2026-09-14 12:30 ` [PATCH proxmox v3 1/2] add proxmox-const-utils crate, factor out checks from proxmox-schema Dominik Csapak
2026-09-14 12:30 ` [PATCH proxmox v3 2/2] router: compile time check privilege path parameters for existence Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260914123243.3216993-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal