From: Shan Shaji <s.shaji@proxmox.com>
To: pdm-devel@lists.proxmox.com
Cc: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
Subject: [PATCH datacenter-manager] api: remote: add permission check for metric collection RRD endpoint
Date: Fri, 28 Aug 2026 17:25:32 +0200 [thread overview]
Message-ID: <20260828152532.214782-1-s.shaji@proxmox.com> (raw)
The /remote/{id}/rrddata endpoint didn't had the access parameter
defined inside the API macro. This resulted in a
"403: permission check failed" error even though the user
was assigned the Administrator role on the / ACL path.
Reported-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
server/src/api/remotes/mod.rs | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/server/src/api/remotes/mod.rs b/server/src/api/remotes/mod.rs
index 5c9fdccf..d6f512f6 100644
--- a/server/src/api/remotes/mod.rs
+++ b/server/src/api/remotes/mod.rs
@@ -625,7 +625,11 @@ impl DataPoint for RemoteDatapoint {
items: {
type: RemoteDatapoint,
}
- }
+ },
+ access: {
+ permission: &Permission::Privilege(&["resource", "{id}"], PRIV_RESOURCE_AUDIT, false),
+ description: "Requires `Resource.Audit` privilege on `/resource/{id}`."
+ },
)]
/// Read metric collection RRD data.
fn get_per_remote_rrd_data(
--
2.47.3
next reply other threads:[~2026-08-28 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 15:25 Shan Shaji [this message]
2026-08-28 15:30 ` [PATCH datacenter-manager] api: remote: add permission check for metric collection RRD endpoint Thomas Ellmenreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260828152532.214782-1-s.shaji@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
--cc=t.ellmenreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox