From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A54701FF0ED for ; Fri, 31 Jul 2026 11:17:04 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 357782152B; Fri, 31 Jul 2026 11:17:02 +0200 (CEST) From: Shannon Sterz To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager 05/15] client: allow users to update a changed fingerprint interactively Date: Fri, 31 Jul 2026 11:16:45 +0200 Message-ID: <20260731091655.93282-6-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260731091655.93282-1-s.sterz@proxmox.com> References: <20260731091655.93282-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785489408060 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.151 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YZ3VEZH47D5FL45NKNJLSUCFMIRKOF6N X-Message-ID-Hash: YZ3VEZH47D5FL45NKNJLSUCFMIRKOF6N X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: if the client is operating in interactive mode and we notice that the certificate of a remote has changed, the client now asks the user whether the certificate should be updated. Signed-off-by: Shannon Sterz --- cli/client/src/env/fingerprint_cache.rs | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/cli/client/src/env/fingerprint_cache.rs b/cli/client/src/env/fingerprint_cache.rs index b9a9f972..cc103347 100644 --- a/cli/client/src/env/fingerprint_cache.rs +++ b/cli/client/src/env/fingerprint_cache.rs @@ -136,16 +136,19 @@ impl FingerprintCache { }; if let Some(stored_fp) = self.entries.read().unwrap().get(hostname) { - return Ok(VerifyResult::unmodified(**stored_fp == *fp)); + if self.interactive && **stored_fp != *fp { + println!("Certificate fingerprint has changed!"); + println!("Old certificate SHA256 fingerprint: {stored_fp}"); + } else { + return Ok(VerifyResult::unmodified(**stored_fp == *fp)); + } + } else if !self.interactive { + return Ok(VerifyResult::unmodified(false)); } let fp = Fingerprint::try_from(&*fp) .map_err(|_| format_err!("unexpected fingerprint length"))?; - if !self.interactive { - return Ok(VerifyResult::unmodified(false)); - } - println!("Certificate SHA256 fingerprint: {fp}"); let mut stdout = std::io::stdout(); -- 2.47.3