From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 24BAE1FF13B for ; Wed, 03 Jun 2026 14:28:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0414AAA80; Wed, 3 Jun 2026 14:28:11 +0200 (CEST) From: Shannon Sterz To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager v2 2/2] server: cache: short-circuit on special max age value 0 Date: Wed, 3 Jun 2026 14:27:33 +0200 Message-ID: <20260603122735.425390-3-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260603122735.425390-1-s.sterz@proxmox.com> References: <20260603122735.425390-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780489620215 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.140 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LXWWVW5OGYMOAOF2K3HTJRBMS4CBASG7 X-Message-ID-Hash: LXWWVW5OGYMOAOF2K3HTJRBMS4CBASG7 X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: a max age of 0 means that the cached information is always considered outdated. instead of reading from the cache first and then checking the max age parameter, simply return early. Signed-off-by: Shannon Sterz --- Notes: note, currently the cache only reads from the tmpfs /run. so the speed-up is likely minimal for now. however, once we persist the cache further this should help a bit. server/src/namespaced_cache.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/server/src/namespaced_cache.rs b/server/src/namespaced_cache.rs index 2f96df41..ccdec92f 100644 --- a/server/src/namespaced_cache.rs +++ b/server/src/namespaced_cache.rs @@ -554,6 +554,10 @@ fn get_impl( // Namespace should already be verified at this point, no point in checking it again. ensure_valid_key(key)?; + if max_age == Some(0) { + return Ok(None); + } + let path = get_path(base, namespace, key); Ok(get_from_path(&path, max_age)?.map(|a| a.value)) -- 2.47.3