From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9C89F1FF14C for ; Fri, 29 May 2026 15:40:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 78E5EC17F; Fri, 29 May 2026 15:39:58 +0200 (CEST) From: Lukas Wagner To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager 1/6] pdm-api-types: add NativeUpid::node() convenience getter Date: Fri, 29 May 2026 15:39:46 +0200 Message-ID: <20260529133951.326103-2-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260529133951.326103-1-l.wagner@proxmox.com> References: <20260529133951.326103-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780061964339 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NTVWYE6MHJT6WXGVEZNJ5VA4XSTNYJO7 X-Message-ID-Hash: NTVWYE6MHJT6WXGVEZNJ5VA4XSTNYJO7 X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Some callers need to get the 'node' property of a UPID, but handle both, PBS and PVE equally, making a distinction at the call site inconvenient. Providing a 'node' getter in NativeUpid simplifies callers a little. Signed-off-by: Lukas Wagner --- lib/pdm-api-types/src/remote_upid.rs | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/lib/pdm-api-types/src/remote_upid.rs b/lib/pdm-api-types/src/remote_upid.rs index 1e90bef4..194e4a18 100644 --- a/lib/pdm-api-types/src/remote_upid.rs +++ b/lib/pdm-api-types/src/remote_upid.rs @@ -26,6 +26,16 @@ pub enum NativeUpid { PbsUpid(pbs_api_types::UPID), } +impl NativeUpid { + /// Convenience getter to query the 'node' property of a task. + pub fn node(&self) -> &str { + match self { + NativeUpid::PveUpid(upid) => upid.node.as_str(), + NativeUpid::PbsUpid(upid) => upid.node.as_str(), + } + } +} + impl RemoteUpid { /// Create a new remote UPID. pub fn new(remote: String, remote_type: RemoteType, upid: String) -> Self { -- 2.47.3