From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DBF3D1FF14C for ; Fri, 29 May 2026 15:30:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C7A10BC53; Fri, 29 May 2026 15:30:30 +0200 (CEST) From: Dominik Csapak To: pdm-devel@lists.proxmox.com Subject: [RFC PATCH datacenter-manager 1/4] server: connection: multi client: use correct client error for retrying Date: Fri, 29 May 2026 15:30:17 +0200 Message-ID: <20260529133026.3149896-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260529133026.3149896-1-d.csapak@proxmox.com> References: <20260529133026.3149896-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [connection.rs] Message-ID-Hash: QYW5FM5TOBGQ3KYTKFNO3TNOTT7IHPWO X-Message-ID-Hash: QYW5FM5TOBGQ3KYTKFNO3TNOTT7IHPWO X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Since commit 8e3b1f06 (client: split out Connect error and factor out error classification) in the proxmox workspace, Connection errors are split out to it's own type of `proxmox_client::Error`s. Since then, every connection error was returned normally and not retried via other hosts from the remote config. Use the correct error type to only retry when the actual connection is not working, not if the api or the server returns an issue. Signed-off-by: Dominik Csapak --- Not sure if just changing this is a good idea, or if we want to catch both connect and client errors? tracking only connect errors seemed the correct way to me here, but maybe someone has a different opinion. server/src/connection.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/connection.rs b/server/src/connection.rs index 93f173e6..28e4799f 100644 --- a/server/src/connection.rs +++ b/server/src/connection.rs @@ -744,7 +744,7 @@ macro_rules! try_request { let request = client.$how($method.clone(), $path_and_query, params.as_ref()); match tokio::time::timeout($self.timeout, request).await { - Ok(Err(proxmox_client::Error::Client(err))) => { + Ok(Err(proxmox_client::Error::Connect(err))) => { last_err = Some(err); } Ok(result) => { -- 2.47.3