public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH datacenter-manager] ui: guest view: improve contrast for placeholder text/icon
Date: Wed, 27 May 2026 09:07:33 +0200	[thread overview]
Message-ID: <20260527070733.38398-1-l.wagner@proxmox.com> (raw)

The icon and status text is shown if there is e.g. no guest matching the
current filter. The "NeutralAlt" color does not have a good enough
contrast to be clearly legible (especially in dark mode), so use default
text color instead.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 ui/src/guests.rs | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/ui/src/guests.rs b/ui/src/guests.rs
index c912867e..85faf71a 100644
--- a/ui/src/guests.rs
+++ b/ui/src/guests.rs
@@ -24,7 +24,7 @@ use proxmox_yew_comp::{
     LoadableComponentScope, LoadableComponentScopeExt, LoadableComponentState,
 };
 
-use pwt::css::{AlignItems, ColorScheme, FlexFit, FontColor, FontStyle, JustifyContent};
+use pwt::css::{AlignItems, ColorScheme, FlexFit, FontStyle, JustifyContent};
 use pwt::prelude::*;
 use pwt::props::{
     ContainerBuilder, CssPaddingBuilder, ExtractPrimaryKey, StorageLocation, WidgetBuilder,
@@ -614,17 +614,13 @@ fn empty_state(icon: &str, title: String, hint: String) -> Html {
         .class(AlignItems::Center)
         .gap(2)
         .padding(4)
-        .with_child(Fa::new(icon).large_3x().class(FontColor::NeutralAlt))
+        .with_child(Fa::new(icon).large_3x())
         .with_child(
             Container::from_tag("span")
                 .class(FontStyle::TitleMedium)
                 .with_child(title),
         )
-        .with_child(
-            Container::from_tag("span")
-                .class(FontColor::NeutralAlt)
-                .with_child(hint),
-        )
+        .with_child(Container::from_tag("span").with_child(hint))
         .into()
 }
 
-- 
2.47.3





             reply	other threads:[~2026-05-27  7:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27  7:07 Lukas Wagner [this message]
2026-05-27  8:02 ` applied: [PATCH datacenter-manager] ui: guest view: improve contrast for placeholder text/icon Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260527070733.38398-1-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal