From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH 1/8] api: subscription cache: ensure max_age=0 forces a fresh fetch
Date: Thu, 7 May 2026 09:17:24 +0200 [thread overview]
Message-ID: <20260507072436.2649563-2-t.lamprecht@proxmox.com> (raw)
In-Reply-To: <20260507072436.2649563-1-t.lamprecht@proxmox.com>
The cache lookup used 'diff > max_age', so a same-second hit with
max_age=0 still returned cached data; collect_status_uncached and the
direct user-supplied ?max-age=0 bypass both silently lost their
freshness guarantee. Short-circuit max_age=0 explicitly and switch the
TTL comparison to '>=' so the boundary is an exact miss.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
This threw me off quite a bit, as I observed seemingly stale cache
issues, which where ultimately due to something completely different.
server/src/api/resources.rs | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/server/src/api/resources.rs b/server/src/api/resources.rs
index 04628a8..50315b1 100644
--- a/server/src/api/resources.rs
+++ b/server/src/api/resources.rs
@@ -830,11 +830,14 @@ fn get_cached_subscription_info(remote: &str, max_age: u64) -> Option<CachedSubs
.read()
.expect("subscription mutex poisoned");
+ if max_age == 0 {
+ return None;
+ }
if let Some(cached_subscription) = cache.get(remote) {
let now = proxmox_time::epoch_i64();
let diff = now - cached_subscription.timestamp;
- if diff > max_age as i64 || diff < 0 {
+ if diff >= max_age as i64 || diff < 0 {
// value is too old or from the future
None
} else {
--
2.47.3
next prev parent reply other threads:[~2026-05-07 7:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 7:17 [PATCH 0/8] subscription: add central key pool registry with reissue support Thomas Lamprecht
2026-05-07 7:17 ` Thomas Lamprecht [this message]
2026-05-07 7:17 ` [PATCH 2/8] api types: subscription level: render full names Thomas Lamprecht
2026-05-07 7:17 ` [PATCH 3/8] subscription: add key pool data model and config layer Thomas Lamprecht
2026-05-07 7:17 ` [PATCH 4/8] subscription: add key pool and node status API endpoints Thomas Lamprecht
2026-05-07 7:17 ` [PATCH 5/8] ui: add subscription registry with key pool and node status Thomas Lamprecht
2026-05-07 8:15 ` Lukas Wagner
2026-05-07 8:33 ` Thomas Lamprecht
2026-05-07 7:17 ` [PATCH 6/8] cli: add subscription key pool management subcommands Thomas Lamprecht
2026-05-07 7:17 ` [PATCH 7/8] docs: add subscription registry chapter Thomas Lamprecht
2026-05-07 7:17 ` [PATCH 8/8] subscription: add Reissue Key action with pending-reissue queue Thomas Lamprecht
2026-05-07 7:50 ` Lukas Wagner
2026-05-07 8:38 ` superseded: [PATCH 0/8] subscription: add central key pool registry with reissue support Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260507072436.2649563-2-t.lamprecht@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox