From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BC79F1FF13F for ; Thu, 12 Mar 2026 14:53:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B7EBB17642; Thu, 12 Mar 2026 14:53:14 +0100 (CET) From: Lukas Wagner To: pdm-devel@lists.proxmox.com Subject: [PATCH proxmox 05/26] parallel-handler: add simple unit-test suite Date: Thu, 12 Mar 2026 14:52:06 +0100 Message-ID: <20260312135229.420729-6-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260312135229.420729-1-l.wagner@proxmox.com> References: <20260312135229.420729-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773323522320 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: C5MZHGXSM7ZIGKHFVKUAM7JYFNRWM62J X-Message-ID-Hash: C5MZHGXSM7ZIGKHFVKUAM7JYFNRWM62J X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Add a simple test suite to the new proxmox-parallel-handler crate to avoid any future regressions. --- proxmox-parallel-handler/src/lib.rs | 73 +++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/proxmox-parallel-handler/src/lib.rs b/proxmox-parallel-handler/src/lib.rs index 38f6a48a..91dac17d 100644 --- a/proxmox-parallel-handler/src/lib.rs +++ b/proxmox-parallel-handler/src/lib.rs @@ -269,3 +269,76 @@ impl Drop for ParallelHandler { } } } + +#[cfg(test)] +mod tests { + use super::*; + use std::sync::atomic::{AtomicUsize, Ordering}; + + #[test] + fn test_send_on_pool() { + let count = Arc::new(AtomicUsize::new(0)); + let count_clone = Arc::clone(&count); + + let pool = ParallelHandler::new("ok", 2, move |_: u32| { + count_clone.fetch_add(1, Ordering::Relaxed); + Ok(()) + }); + + for i in 0..10 { + pool.send(i).unwrap(); + } + + pool.complete().unwrap(); + assert_eq!(count.load(Ordering::Relaxed), 10); + } + + #[test] + fn test_send_on_handle() { + let count = Arc::new(AtomicUsize::new(0)); + let count_clone = Arc::clone(&count); + + let pool = ParallelHandler::new("chan", 2, move |_: u32| { + count_clone.fetch_add(1, Ordering::Relaxed); + Ok(()) + }); + + let handle = pool.channel(); + for i in 0..5 { + handle.send(i).unwrap(); + } + drop(handle); + + pool.complete().unwrap(); + assert_eq!(count.load(Ordering::Relaxed), 5); + } + + #[test] + fn handler_error_is_propagated_on_complete() { + let pool = ParallelHandler::new("fail", 1, |_: u32| { + anyhow::bail!("boom"); + }); + + pool.send(1).unwrap(); + let err = pool.complete().unwrap_err(); + + match err { + Error::HandlerFailed(msg) => assert!(msg.contains("boom")), + _ => panic!("invalid error variant"), + } + } + + #[test] + fn thread_panic_is_reported_on_complete() { + let pool = ParallelHandler::new("panic", 1, |_: u32| -> Result<(), anyhow::Error> { + panic!("boom"); + }); + + pool.send(1).unwrap(); + let err = pool.complete().unwrap_err(); + match err { + Error::ThreadPanicked { message, .. } => assert!(message.unwrap().contains("boom")), + _ => panic!("invalid error variant"), + } + } +} -- 2.47.3