From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7EF8A1FF137 for ; Tue, 03 Mar 2026 09:17:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 150EAE350; Tue, 3 Mar 2026 09:18:38 +0100 (CET) From: Lukas Wagner To: pdm-devel@lists.proxmox.com Subject: [PATCH proxmox-yew-comp v5 2/2] loadable component: don't trigger reload when starting a task Date: Tue, 3 Mar 2026 09:18:25 +0100 Message-ID: <20260303081831.94431-3-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260303081831.94431-1-l.wagner@proxmox.com> References: <20260303081831.94431-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772525890895 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XLD22QKCC7VRNJN63FICSI7CCROHWZCB X-Message-ID-Hash: XLD22QKCC7VRNJN63FICSI7CCROHWZCB X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The view will be reloaded anyways when the task viewer closes. Usually, one wants to start a new task to produce/refresh some data which should later be displayed in the component, so it makes little sense to reload before the task actually finishes. This avoids an issue with the previous commit. The double-load would reset 'fresh_load' after the first load, leading to the new data not being correctly displayed after the second load. Signed-off-by: Lukas Wagner Reviewed-by: Shannon Sterz --- src/loadable_component.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/loadable_component.rs b/src/loadable_component.rs index 0235f17..2ec2ad9 100644 --- a/src/loadable_component.rs +++ b/src/loadable_component.rs @@ -332,7 +332,6 @@ impl self.send_message(Msg::Spawn(Box::pin(async move { match command_future.await { Ok(task_id) => { - link.send_reload(); if short { link.show_task_progres(task_id); } else { -- 2.47.3