From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 840451FF138 for ; Wed, 18 Feb 2026 17:42:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 567F578B; Wed, 18 Feb 2026 17:43:55 +0100 (CET) From: Shan Shaji To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager v4 4/6] fix #6914: cli-client: add option to delete token from remote Date: Wed, 18 Feb 2026 17:41:32 +0100 Message-ID: <20260218164135.413762-5-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260218164135.413762-1-s.shaji@proxmox.com> References: <20260218164135.413762-1-s.shaji@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771433023404 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.110 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7XA3GJEUC6OLM75UR6QN4FKHZWLHLXQG X-Message-ID-Hash: 7XA3GJEUC6OLM75UR6QN4FKHZWLHLXQG X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The `delete-token` option will be `true` by default. If not specified the token will be deleted automatically. Inorder to skip the token deletion, set the `delete-token` to `false`. Signed-off-by: Shan Shaji --- changes since v3: Thanks @Lukas - change description. - added `default` to the schema and dropped `type`. - update commit message. cli/client/src/remotes.rs | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/cli/client/src/remotes.rs b/cli/client/src/remotes.rs index 4145dac..e087809 100644 --- a/cli/client/src/remotes.rs +++ b/cli/client/src/remotes.rs @@ -116,12 +116,17 @@ async fn update_remote(id: String, updater: RemoteUpdater) -> Result<(), Error> input: { properties: { id: { schema: REMOTE_ID_SCHEMA }, + "delete-token": { + optional: true, + default: true, + description: "If set to false, token deletion on the remote is skipped." + } } } )] -/// Add a new remote. -async fn delete_remote(id: String) -> Result<(), Error> { - client()?.delete_remote(&id).await?; +/// Delete a remote. +async fn delete_remote(id: String, delete_token: bool) -> Result<(), Error> { + client()?.delete_remote(&id, Some(delete_token)).await?; Ok(()) } -- 2.47.3