From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id AEE301FF138 for ; Wed, 18 Feb 2026 17:43:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 95B5A8CF; Wed, 18 Feb 2026 17:44:20 +0100 (CET) From: Shan Shaji To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager/proxmox v4 0/7] fix #6914: add option to remove already existing token Date: Wed, 18 Feb 2026 17:41:28 +0100 Message-ID: <20260218164135.413762-1-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771433017791 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.111 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YK2PZOLGJAJ6SJHA7RORY6MWDGF7D2LR X-Message-ID-Hash: YK2PZOLGJAJ6SJHA7RORY6MWDGF7D2LR X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: If a user removed a remote without deleting its associated token, PDM would not allow re-adding the same remote unless the token was changed. To fix this, support for optionally deleting the token on the remote has been added. new changes: - use ConfirmDialog widget for creating the confirmation dialog. - add token deletion as opt-out feature. History ======= changes since v3: Thanks @Lukas and @Maximiliano - addressed nit comments. - percent-encode the `userid` parameter. - rename PbsClient's delete_admin_token function to delete_token. - by default set the CLIs `delete-token` option to `true`. So by default the token will be deleted unless the option is set to false. - remove `type` attribute from the `delete-token` schema. - fix the alignment of checkbox and text. changes since v2: - regenerate the `delete_token` method. The new generate code has `percent_encoding` wrapped around the params to handle non-alphanumeric characters. changes since v3: - locked the remote config inorder to avoid race condition. Thanks @Michael - included missing admin cli implementation. Thanks @Michael - addressed nit comments. Thanks @Shannon proxmox-datacenter-manager: Shan Shaji (6): server: pbs-client: add method to delete token from remote fix #6914: api: add support to delete token from remote pdm-client: accept `delete-token` argument for deleting api token fix #6914: cli-client: add option to delete token from remote fix #6914: ui: add remove remote dialog with optional token deletion fix #6914: cli-admin: add option to delete token from remote cli/admin/src/remotes.rs | 17 ++++-- cli/client/src/remotes.rs | 11 +++- lib/pdm-client/src/lib.rs | 11 +++- server/src/api/remotes.rs | 46 +++++++++++++- server/src/pbs_client.rs | 16 ++++- ui/src/remotes/config.rs | 38 ++++++++---- ui/src/remotes/mod.rs | 2 + ui/src/remotes/remove_remote.rs | 103 ++++++++++++++++++++++++++++++++ 8 files changed, 222 insertions(+), 22 deletions(-) create mode 100644 ui/src/remotes/remove_remote.rs proxmox: Shan Shaji (1): pve-api-types: generate missing `delete_token` method pve-api-types/generate.pl | 1 + pve-api-types/src/generated/code.rs | 15 +++++++++++++++ 2 files changed, 16 insertions(+) Summary over all repositories: 10 files changed, 238 insertions(+), 22 deletions(-) -- Generated by git-murpp 0.8.1