From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 143DC1FF13B for ; Wed, 11 Feb 2026 16:19:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4835231887; Wed, 11 Feb 2026 16:20:42 +0100 (CET) From: Shan Shaji To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager v3 6/6] cli: admin: add `delete-token` option to delete token from remote Date: Wed, 11 Feb 2026 16:20:15 +0100 Message-ID: <20260211152016.445817-7-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260211152016.445817-1-s.shaji@proxmox.com> References: <20260211152016.445817-1-s.shaji@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770823150845 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.112 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LOCTAEPMIVRSDJAWP5M2W7NFWKPTPLYL X-Message-ID-Hash: LOCTAEPMIVRSDJAWP5M2W7NFWKPTPLYL X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Inorder to allow deleting the remote API token from PDM, added optional boolean flag. Signed-off-by: Shan Shaji --- **note**: No changes since v2. This was not included in v1. cli/admin/src/remotes.rs | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/cli/admin/src/remotes.rs b/cli/admin/src/remotes.rs index edd3fd8..6702667 100644 --- a/cli/admin/src/remotes.rs +++ b/cli/admin/src/remotes.rs @@ -217,16 +217,28 @@ fn update_remote( input: { properties: { id: { schema: REMOTE_ID_SCHEMA }, + "delete-token": { + type: bool, + optional: true, + description: "Remove the API-Token from remote." + } } } )] -/// Add a new remote. -fn remove_remote(id: String, rpcenv: &mut dyn RpcEnvironment) -> Result<(), Error> { - let param = json!({ "id": id }); +/// Remove a new remote. +async fn remove_remote( + id: String, + delete_token: Option, + rpcenv: &mut dyn RpcEnvironment, +) -> Result<(), Error> { + let mut param = json!({ "id": id }); + if delete_token.is_some() { + param["delete-token"] = delete_token.into(); + } let info = &dc_api::remotes::API_METHOD_REMOVE_REMOTE; match info.handler { - ApiHandler::Sync(handler) => (handler)(param, info, rpcenv).map(drop), + ApiHandler::Async(handler) => (handler)(param, info, rpcenv).await.map(drop), _ => unreachable!(), } } -- 2.47.3