From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 37A5F1FF13B for ; Wed, 11 Feb 2026 16:19:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7B0CA316A8; Wed, 11 Feb 2026 16:20:35 +0100 (CET) From: Shan Shaji To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager/proxmox v3 0/7] fix #6914: add option to remove already existing token Date: Wed, 11 Feb 2026 16:20:09 +0100 Message-ID: <20260211152016.445817-1-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770823143203 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.112 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GOODNRLEXW77PUYNRTUM63OGB22NJV7G X-Message-ID-Hash: GOODNRLEXW77PUYNRTUM63OGB22NJV7G X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: **note**: Sending v3 because the generated code for the delete_token method in pve-api-types has changed. I rebased the series onto master and re-tested the changes. If a user removed a remote without deleting its associated token, PDM would not allow re-adding the same remote unless the token was changed. To fix this, support for optionally deleting the token from the remote has been added. This patch series adds support to delete the token using an optional boolean flag in CLIs ie. on both admin and client. Additionaly, added a check box inside the UI that allow users to choose whether to delete the token while removing the remote. History ======= changes since v2: - Regenerate the `delete_token` method. The new generate code has `percent_encoding` wrapped around the params to handle non-alphanumeric characters. changes since v3: - Locked the remote config inorder to avoid race condition. Thanks @Michael - Included missing admin cli implementation. Thanks @Michael - Addressed nit comments. Thanks @Shannon proxmox-datacenter-manager: Shan Shaji (6): server: pbs-client: add delete admin token method server: api: add support to optionally delete token from remote pdm-client: accept `delete-token` argument for deleting api token cli: client: add `delete-token` option to delete token from remote fix: ui: add remove confirmation dialog with optional token deletion cli: admin: add `delete-token` option to delete token from remote cli/admin/src/remotes.rs | 20 ++++-- cli/client/src/remotes.rs | 11 ++- lib/pdm-client/src/lib.rs | 11 ++- server/src/api/remotes.rs | 46 ++++++++++++- server/src/pbs_client.rs | 7 ++ ui/src/remotes/config.rs | 38 ++++++++--- ui/src/remotes/mod.rs | 2 + ui/src/remotes/remove_remote.rs | 117 ++++++++++++++++++++++++++++++++ 8 files changed, 231 insertions(+), 21 deletions(-) create mode 100644 ui/src/remotes/remove_remote.rs proxmox: Shan Shaji (1): pve-api-types: generate missing `delete_token` method pve-api-types/generate.pl | 1 + pve-api-types/src/generated/code.rs | 15 +++++++++++++++ 2 files changed, 16 insertions(+) Summary over all repositories: 10 files changed, 247 insertions(+), 21 deletions(-) -- Generated by git-murpp 0.8.1