From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6CC841FF13E for ; Fri, 06 Feb 2026 17:35:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 114B5B547; Fri, 6 Feb 2026 17:35:34 +0100 (CET) From: Shan Shaji To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager 2/2] fix: cli: remove completion files for service bins Date: Fri, 6 Feb 2026 17:35:19 +0100 Message-ID: <20260206163519.218579-3-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260206163519.218579-1-s.shaji@proxmox.com> References: <20260206163519.218579-1-s.shaji@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770395651394 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.111 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2QHJVW3SXIASAMNVIR6JNT25UDV2S2YA X-Message-ID-Hash: 2QHJVW3SXIASAMNVIR6JNT25UDV2S2YA X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Passing the `bashcomplete` argument to proxmox-datacenter-api and proxmox-datacenter-privileged-api results in an error instead of generating completions. Since these binaries are systemd-managed service executables rather than user facing CLI tools, providing bash completion helpers is not useful. Signed-off-by: Shan Shaji --- Makefile | 4 ++-- debian/proxmox-datacenter-manager.install | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index b10fed7..940a2e7 100644 --- a/Makefile +++ b/Makefile @@ -53,8 +53,8 @@ COMPILED_BINS := \ $(addprefix $(COMPILEDIR)/,$(USR_BIN) $(USR_SBIN) $(SERVICE_BIN) $(INTERNAL_SERVICE_BIN)) # completion helper get generated on build -BASH_COMPLETIONS := $(addsuffix .bash,$(USR_BIN) $(USR_SBIN) $(SERVICE_BIN)) -ZSH_COMPLETIONS := $(addprefix _,$(USR_BIN) $(USR_SBIN) $(SERVICE_BIN)) +BASH_COMPLETIONS := $(addsuffix .bash,$(USR_BIN) $(USR_SBIN)) +ZSH_COMPLETIONS := $(addprefix _,$(USR_BIN) $(USR_SBIN)) SHELL_COMPLETION_FILES := $(addprefix $(COMPLETION_DIR)/,$(BASH_COMPLETIONS) $(ZSH_COMPLETIONS)) tests ?= --workspace diff --git a/debian/proxmox-datacenter-manager.install b/debian/proxmox-datacenter-manager.install index 7942146..001d727 100644 --- a/debian/proxmox-datacenter-manager.install +++ b/debian/proxmox-datacenter-manager.install @@ -11,15 +11,11 @@ usr/libexec/proxmox/proxmox-datacenter-privileged-api usr/sbin/pdmAtoB usr/sbin/proxmox-datacenter-manager-admin usr/share/bash-completion/completions/pdmAtoB.bash -usr/share/bash-completion/completions/proxmox-datacenter-api.bash usr/share/bash-completion/completions/proxmox-datacenter-manager-admin.bash -usr/share/bash-completion/completions/proxmox-datacenter-privileged-api.bash usr/share/man/man1/proxmox-datacenter-api.1 usr/share/man/man1/proxmox-datacenter-manager-admin.1 usr/share/man/man1/proxmox-datacenter-privileged-api.1 usr/share/man/man5/remotes.cfg.5 usr/share/man/man5/views.cfg.5 usr/share/zsh/vendor-completions/_pdmAtoB -usr/share/zsh/vendor-completions/_proxmox-datacenter-api usr/share/zsh/vendor-completions/_proxmox-datacenter-manager-admin -usr/share/zsh/vendor-completions/_proxmox-datacenter-privileged-api -- 2.47.3