From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 852F81FF13E for ; Fri, 06 Feb 2026 17:35:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EA23BB3FD; Fri, 6 Feb 2026 17:35:32 +0100 (CET) From: Shan Shaji To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager 1/2] fix: cli: replace completion file suffix from `.bc` to `.bash` Date: Fri, 6 Feb 2026 17:35:18 +0100 Message-ID: <20260206163519.218579-2-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260206163519.218579-1-s.shaji@proxmox.com> References: <20260206163519.218579-1-s.shaji@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770395650510 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.111 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QBV2LBJLNJPCZ6XR5PXQLTLLZCT6LNLJ X-Message-ID-Hash: QBV2LBJLNJPCZ6XR5PXQLTLLZCT6LNLJ X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The completions were not working because of the file name extension of the completion file. According to the `bash-completion` documentation, completion file needs to have a `.bash` suffix or without any suffix. documentation quote: > The completion filename for command `foo` in this directory should be > `foo.bash`. Unsuffixed foo also works, but it is deprecated in >= 2.18. Since the .bash extension works on the current 2.16 bash-completion version available in debian, replaced the `.bc` suffix with `.bash` Signed-off-by: Shan Shaji --- Makefile | 2 +- cli/completions/Makefile | 2 +- debian/proxmox-datacenter-manager-client.install | 2 +- debian/proxmox-datacenter-manager.install | 8 ++++---- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index 91fe684..b10fed7 100644 --- a/Makefile +++ b/Makefile @@ -53,7 +53,7 @@ COMPILED_BINS := \ $(addprefix $(COMPILEDIR)/,$(USR_BIN) $(USR_SBIN) $(SERVICE_BIN) $(INTERNAL_SERVICE_BIN)) # completion helper get generated on build -BASH_COMPLETIONS := $(addsuffix .bc,$(USR_BIN) $(USR_SBIN) $(SERVICE_BIN)) +BASH_COMPLETIONS := $(addsuffix .bash,$(USR_BIN) $(USR_SBIN) $(SERVICE_BIN)) ZSH_COMPLETIONS := $(addprefix _,$(USR_BIN) $(USR_SBIN) $(SERVICE_BIN)) SHELL_COMPLETION_FILES := $(addprefix $(COMPLETION_DIR)/,$(BASH_COMPLETIONS) $(ZSH_COMPLETIONS)) diff --git a/cli/completions/Makefile b/cli/completions/Makefile index 5972355..5e7b2f7 100644 --- a/cli/completions/Makefile +++ b/cli/completions/Makefile @@ -2,7 +2,7 @@ all: # bash completion -%.bc: +%.bash: @echo "creating bash completion definition for $*" @printf '# $* bash completion\n\n' >$@.tmp @printf "complete -C '$* bashcomplete' $*\n" >>$@.tmp diff --git a/debian/proxmox-datacenter-manager-client.install b/debian/proxmox-datacenter-manager-client.install index 1844173..eb9d782 100644 --- a/debian/proxmox-datacenter-manager-client.install +++ b/debian/proxmox-datacenter-manager-client.install @@ -1,4 +1,4 @@ usr/bin/proxmox-datacenter-manager-client -usr/share/bash-completion/completions/proxmox-datacenter-manager-client.bc +usr/share/bash-completion/completions/proxmox-datacenter-manager-client.bash usr/share/man/man1/proxmox-datacenter-manager-client.1 usr/share/zsh/vendor-completions/_proxmox-datacenter-manager-client diff --git a/debian/proxmox-datacenter-manager.install b/debian/proxmox-datacenter-manager.install index 499e07f..7942146 100644 --- a/debian/proxmox-datacenter-manager.install +++ b/debian/proxmox-datacenter-manager.install @@ -10,10 +10,10 @@ usr/libexec/proxmox/proxmox-datacenter-manager-daily-update usr/libexec/proxmox/proxmox-datacenter-privileged-api usr/sbin/pdmAtoB usr/sbin/proxmox-datacenter-manager-admin -usr/share/bash-completion/completions/pdmAtoB.bc -usr/share/bash-completion/completions/proxmox-datacenter-api.bc -usr/share/bash-completion/completions/proxmox-datacenter-manager-admin.bc -usr/share/bash-completion/completions/proxmox-datacenter-privileged-api.bc +usr/share/bash-completion/completions/pdmAtoB.bash +usr/share/bash-completion/completions/proxmox-datacenter-api.bash +usr/share/bash-completion/completions/proxmox-datacenter-manager-admin.bash +usr/share/bash-completion/completions/proxmox-datacenter-privileged-api.bash usr/share/man/man1/proxmox-datacenter-api.1 usr/share/man/man1/proxmox-datacenter-manager-admin.1 usr/share/man/man1/proxmox-datacenter-privileged-api.1 -- 2.47.3